From: sagar.tv@gmail.com (Vidya Sagar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: fix debug prints relevant to PCI devices
Date: Sun, 7 Sep 2014 15:58:07 +0530 [thread overview]
Message-ID: <1410085687-11273-1-git-send-email-vidyas@nvidia.com> (raw)
From: Vidya Sagar <sagar.tv@gmail.com>
As per PCIe spec, fast back-to-back transactions feature
is not applicable to PCIe devices. Hence, do not print
that fast back-to-back trasactions are disabled when
there is a PCIe device found on the bus
Signed-off-by: Vidya Sagar <sagar.tv@gmail.com>
---
v4:
* initialized 'has_pcie_dev' to 'false'
v3:
* removed KERN_INFO from pr_info() which was not removed by mistake in previous patch
v2:
* Modified has_pcie_dev type to bool and used pci_is_pcie() instead of pci_pcie_cap()
* replaced printk with pr_info
arch/arm/kernel/bios32.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
index 17a26c1..03c56ba 100644
--- a/arch/arm/kernel/bios32.c
+++ b/arch/arm/kernel/bios32.c
@@ -290,6 +290,7 @@ void pcibios_fixup_bus(struct pci_bus *bus)
{
struct pci_dev *dev;
u16 features = PCI_COMMAND_SERR | PCI_COMMAND_PARITY | PCI_COMMAND_FAST_BACK;
+ bool has_pcie_dev = false;
/*
* Walk the devices on this bus, working out what we can
@@ -298,6 +299,8 @@ void pcibios_fixup_bus(struct pci_bus *bus)
list_for_each_entry(dev, &bus->devices, bus_list) {
u16 status;
+ if (!has_pcie_dev)
+ has_pcie_dev = pci_is_pcie(dev);
pci_read_config_word(dev, PCI_STATUS, &status);
/*
@@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
/*
* Report what we did for this bus
+ * (only if the bus doesn't have any PCIe devices)
*/
- printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
- bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
+ if (!has_pcie_dev)
+ pr_info("PCI: bus%d: Fast back to back transfers %sabled\n",
+ bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
}
EXPORT_SYMBOL(pcibios_fixup_bus);
--
1.8.1.5
next reply other threads:[~2014-09-07 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 10:28 Vidya Sagar [this message]
2014-09-11 19:46 ` [PATCH v4] ARM: fix debug prints relevant to PCI devices vidya sagar
2014-09-23 13:56 ` Bjorn Helgaas
2014-09-23 14:06 ` Russell King - ARM Linux
2014-09-23 15:04 ` Thierry Reding
2014-09-23 15:56 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-06-22 12:44 Vidya Sagar
2014-06-19 6:36 Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410085687-11273-1-git-send-email-vidyas@nvidia.com \
--to=sagar.tv@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).