From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: vexpress: Remove non-DT code
Date: Wed, 17 Sep 2014 16:46:00 +0100 [thread overview]
Message-ID: <1410968760.30394.7.camel@hornet> (raw)
In-Reply-To: <20140917154212.GD30918@lee--X1>
On Wed, 2014-09-17 at 16:42 +0100, Lee Jones wrote:
> On Wed, 17 Sep 2014, Pawel Moll wrote:
> > On Wed, 2014-09-17 at 00:30 +0100, Lee Jones wrote:
> > > On Wed, 10 Sep 2014, Pawel Moll wrote:
> > >
> > > > Now, with the CLCD DT support available, there is no
> > > > more reason to keep the non-DT support for V2P-CA9.
> > > >
> > > > Removed, together with "some" supporting code. It was
> > > > necessary to make PLAT_VERSATILE_SCHED_CLOCK optional
> > > > and selected by the machines still interested in it.
> > > >
> > > > Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> > > > ---
> > > > arch/arm/Kconfig | 2 +
> > > > arch/arm/mach-vexpress/Kconfig | 3 -
> > > > arch/arm/mach-vexpress/Makefile | 3 +-
> > > > arch/arm/mach-vexpress/core.h | 7 -
> > > > arch/arm/mach-vexpress/ct-ca9x4.c | 212 ------------
> > > > arch/arm/mach-vexpress/include/mach/ct-ca9x4.h | 47 ---
> > > > arch/arm/mach-vexpress/include/mach/hardware.h | 1 -
> > > > arch/arm/mach-vexpress/include/mach/irqs.h | 6 -
> > > > arch/arm/mach-vexpress/include/mach/motherboard.h | 88 -----
> > > > arch/arm/mach-vexpress/platsmp.c | 42 ---
> > > > arch/arm/mach-vexpress/v2m.c | 374 ----------------------
> > > > arch/arm/plat-versatile/Kconfig | 2 +-
> > > > drivers/clk/versatile/Makefile | 1 -
> > > > drivers/clk/versatile/clk-vexpress-osc.c | 7 -
> > > > drivers/clk/versatile/clk-vexpress.c | 86 -----
> > > > drivers/mfd/vexpress-sysreg.c | 71 +---
> > > > drivers/misc/vexpress-syscfg.c | 60 +---
> > > > drivers/power/reset/vexpress-poweroff.c | 17 +-
> > > > include/linux/vexpress.h | 19 --
> > > > 19 files changed, 35 insertions(+), 1013 deletions(-)
> > > > delete mode 100644 arch/arm/mach-vexpress/ct-ca9x4.c
> > > > delete mode 100644 arch/arm/mach-vexpress/include/mach/ct-ca9x4.h
> > > > delete mode 100644 arch/arm/mach-vexpress/include/mach/hardware.h
> > > > delete mode 100644 arch/arm/mach-vexpress/include/mach/irqs.h
> > > > delete mode 100644 arch/arm/mach-vexpress/include/mach/motherboard.h
> > > > delete mode 100644 drivers/clk/versatile/clk-vexpress.c
> > >
> > > Is it really necessary to take the one-big-patch approach? I'm sure
> > > you can find a nicer way than to burden all these maintainers.
> > > Naturally I can't speak for everyone concerned, but I don't really
> > > want to be carrying all this if I don't have to. Granted I'm not
> > > carrying any patches touching drivers/mfd/vexpress-sysreg.c at the
> > > moment, but equally I don't want to rule that out.
> >
> > I feel that getting all this stuff done (notice: no new features, just
> > removing existing stuff) was the simplest approach, without having to
> > rely on patches being merged in particular order.
> >
> > Besides, there are three things there that are not directly maintained
> > by the arm-soc folk: clk (already acked by Mike), mfd (you) and
> > power/reset. So I thought that gathering acks for those and getting it
> > merged via arm-soc would be the simplest approach...
>
> It's certainly the easiest approach for you, but it makes things
> difficult for the maintainers as it would entail all 4 entities
> carrying the patch. The alternative is to hope there won't be any
> subsequent changes to the files in our respective subsystems which
> might cause conflicts. I'm not keen on the latter idea.
No problem, I will factor out the mfd and reset stuff and post it
separately after the main changes are merged.
Pawel
next prev parent reply other threads:[~2014-09-17 15:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 14:33 [PATCH 1/2] ARM: vexpress: Add CLCD Device Tree properties Pawel Moll
2014-09-10 14:33 ` [PATCH 2/2] ARM: vexpress: Remove non-DT code Pawel Moll
2014-09-10 14:58 ` Russell King - ARM Linux
2014-09-10 15:40 ` Pawel Moll
2014-09-17 15:27 ` Russell King - ARM Linux
2014-09-17 16:11 ` Pawel Moll
2014-09-18 1:04 ` Nicolas Pitre
2014-09-18 7:57 ` Russell King - ARM Linux
2014-09-18 9:19 ` Pawel Moll
2014-09-18 17:17 ` Nicolas Pitre
2014-09-10 17:45 ` Mike Turquette
2014-09-16 23:30 ` Lee Jones
2014-09-17 14:59 ` Pawel Moll
2014-09-17 15:42 ` Lee Jones
2014-09-17 15:46 ` Pawel Moll [this message]
2014-09-17 16:54 ` Lee Jones
2014-09-17 16:43 ` [PATCH v2] " Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410968760.30394.7.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).