linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] ARM: mvebu: armada-xp: Move GE0/1 pinctrl settings for RGMII
Date: Fri, 19 Sep 2014 22:14:40 +0200	[thread overview]
Message-ID: <1411157684-6991-5-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1411157684-6991-1-git-send-email-sebastian.hesselbarth@gmail.com>

Pinctrl settings for GE0 and GE1 are not only usable on RD-AXPWiFiAP.
Moreover, naming the RGMII settings pmx-ge{0,1} is not precise enough
as there is also a GMII setting for GE0.

Move the pinctrl sub-nodes to the common pinctrl node and rename them
to pmx-ge{0,1}-rgmii.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: devicetree at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
 arch/arm/boot/dts/armada-xp-axpwifiap.dts | 18 ++----------------
 arch/arm/boot/dts/armada-xp.dtsi          | 16 ++++++++++++++++
 2 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/arch/arm/boot/dts/armada-xp-axpwifiap.dts b/arch/arm/boot/dts/armada-xp-axpwifiap.dts
index cdab007fbaf4..0e53fad111de 100644
--- a/arch/arm/boot/dts/armada-xp-axpwifiap.dts
+++ b/arch/arm/boot/dts/armada-xp-axpwifiap.dts
@@ -84,14 +84,14 @@
 			};
 
 			ethernet at 70000 {
-				pinctrl-0 = <&pmx_ge0>;
+				pinctrl-0 = <&pmx_ge0_rgmii>;
 				pinctrl-names = "default";
 				status = "okay";
 				phy = <&phy0>;
 				phy-mode = "rgmii-id";
 			};
 			ethernet at 74000 {
-				pinctrl-0 = <&pmx_ge1>;
+				pinctrl-0 = <&pmx_ge1_rgmii>;
 				pinctrl-names = "default";
 				status = "okay";
 				phy = <&phy1>;
@@ -133,20 +133,6 @@
 	pinctrl-0 = <&pmx_phy_int>;
 	pinctrl-names = "default";
 
-	pmx_ge0: pmx-ge0 {
-		marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3",
-			       "mpp4", "mpp5", "mpp6", "mpp7",
-			       "mpp8", "mpp9", "mpp10", "mpp11";
-		marvell,function = "ge0";
-	};
-
-	pmx_ge1: pmx-ge1 {
-		marvell,pins = "mpp12", "mpp13", "mpp14", "mpp15",
-			       "mpp16", "mpp17", "mpp18", "mpp19",
-			       "mpp20", "mpp21", "mpp22", "mpp23";
-		marvell,function = "ge1";
-	};
-
 	pmx_keys: pmx-keys {
 		marvell,pins = "mpp33";
 		marvell,function = "gpio";
diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
index b5fd8c69dfff..dfbcb10ad0db 100644
--- a/arch/arm/boot/dts/armada-xp.dtsi
+++ b/arch/arm/boot/dts/armada-xp.dtsi
@@ -74,6 +74,22 @@
 			pinctrl: pin-ctrl at 18000 {
 				reg = <0x18000 0x38>;
 
+				pmx_ge0_rgmii: pmx-ge0-rgmii {
+					marvell,pins =
+					     "mpp0", "mpp1", "mpp2", "mpp3",
+					     "mpp4", "mpp5", "mpp6", "mpp7",
+					     "mpp8", "mpp9", "mpp10", "mpp11";
+					marvell,function = "ge0";
+				};
+
+				pmx_ge1_rgmii: pmx-ge1-rgmii {
+					marvell,pins =
+					     "mpp12", "mpp13", "mpp14", "mpp15",
+					     "mpp16", "mpp17", "mpp18", "mpp19",
+					     "mpp20", "mpp21", "mpp22", "mpp23";
+					marvell,function = "ge1";
+				};
+
 				sdio_pins: sdio-pins {
 					marvell,pins = "mpp30", "mpp31", "mpp32",
 						       "mpp33", "mpp34", "mpp35";
-- 
2.0.0

  parent reply	other threads:[~2014-09-19 20:14 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 20:14 [PATCH 0/8] Armada XP pinctrl consolidation and ix4-300d fixes Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 1/8] ARM: mvebu: armada-xp: Consolidate pinctrl node Sebastian Hesselbarth
2014-09-19 20:39   ` Thomas Petazzoni
2014-09-19 20:14 ` [PATCH 2/8] ARM: mvebu: armada-xp: Add node alias to pinctrl and add base address Sebastian Hesselbarth
2014-09-19 20:40   ` Thomas Petazzoni
2014-09-19 20:14 ` [PATCH 3/8] ARM: mvebu: armada-xp: Use pinctrl node alias Sebastian Hesselbarth
2014-09-19 20:42   ` Thomas Petazzoni
2014-09-19 20:14 ` Sebastian Hesselbarth [this message]
2014-09-19 20:14 ` [PATCH 5/8] ARM: mvebu: armada-xp: Add GE0 pinctrl settings for GMII Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 6/8] ARM: mvebu: armada-xp: Add RGMII pinctrl to Lenovo ix4-300d Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 7/8] ARM: mvebu: armada-xp: Add I2C eeprom on " Sebastian Hesselbarth
2014-09-20  9:55   ` Sebastian Hesselbarth
2014-09-19 20:14 ` [PATCH 8/8] ARM: mvebu: armada-xp: Fix 74hc595 count for " Sebastian Hesselbarth
2014-09-21 14:11 ` [PATCH 0/8] Armada XP pinctrl consolidation and ix4-300d fixes Benoit Masson
2014-10-03 14:11   ` Jason Cooper
2014-10-03 15:06     ` Sebastian Hesselbarth
2014-10-03 15:29       ` Benoit Masson
2014-10-03 15:41         ` Sebastian Hesselbarth
2014-10-05 23:11           ` Benoit Masson
2014-10-06  7:47             ` Sebastian Hesselbarth
2014-10-06  8:36               ` Gregory CLEMENT
     [not found]               ` <BAB12F2D-0142-4362-BA04-59D8E6B16AAE@perenite.com>
2014-10-06  9:14                 ` Gregory CLEMENT
2014-10-06 16:13             ` Sebastian Hesselbarth
2014-10-15  0:53               ` Benoit Masson
     [not found]                 ` <1CDF8F6B-42FF-4D6A-B52F-6DB270F2673C@perenite.com>
2014-10-15 14:41                   ` Andrew Lunn
2014-10-15 15:35                     ` Benoit Masson
2014-10-15 14:42                 ` Jason Cooper
2014-10-15 14:49                   ` Sebastian Hesselbarth
2014-10-15 14:55                     ` Andrew Lunn
2014-10-15 15:30                       ` Jason Cooper
2014-10-15 15:56                         ` Jason Cooper
2014-11-01 22:59                 ` Jason Cooper
2014-11-01 22:36 ` Jason Cooper
2014-11-01 22:48   ` Sebastian Hesselbarth
2014-11-02 19:03     ` Jason Cooper
2014-11-02 19:19       ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411157684-6991-5-git-send-email-sebastian.hesselbarth@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).