From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: BCM5301X: select GPIOLIB as optional
Date: Sun, 21 Sep 2014 00:30:22 +0400 [thread overview]
Message-ID: <1411245022.509392841@f140.i.mail.ru> (raw)
In-Reply-To: <CACna6rzf6mVVWHs=6diuCsAAdPsnDpfUL4z6Bv-WChSJC5N3Cg@mail.gmail.com>
Sat, 20 Sep 2014 22:23:00 +0200 ?? Rafa? Mi?ecki <zajec5@gmail.com>:
> On 20 September 2014 22:14, Alexander Shiyan <shc_work@mail.ru> wrote:
> > Sat, 20 Sep 2014 22:00:37 +0200 ?? Rafa? Mi?ecki <zajec5@gmail.com>:
> >> On 20 September 2014 19:00, Alexander Shiyan <shc_work@mail.ru> wrote:
> >> > Sat, 20 Sep 2014 18:41:22 +0200 ?? Rafa? Mi?ecki <zajec5@gmail.com>:
> >> >> All routers (or 99% of them) based on BCM5301X use GPIOs to control LEDs
> >> >> and buttons.
> >> >>
> >> >> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> >> >> ---
> >> >> arch/arm/mach-bcm/Kconfig | 2 ++
> >> >> 1 file changed, 2 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> >> >> index fc93800..d967c98 100644
> >> >> --- a/arch/arm/mach-bcm/Kconfig
> >> >> +++ b/arch/arm/mach-bcm/Kconfig
> >> >> @@ -80,8 +80,10 @@ config ARCH_BCM2835
> >> >>
> >> >> config ARCH_BCM_5301X
> >> >> bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7
> >> >> + select ARCH_WANT_OPTIONAL_GPIOLIB
> >> >> select ARM_GIC
> >> >> select CACHE_L2X0
> >> >> + select GPIOLIB
> >> > ...
> >> >
> >> > GPIOLIB is selected automatically by ARCH_WANT_OPTIONAL_GPIOLIB.
> >>
> >> I don't think so, I believe selecting is done by ARCH_REQUIRE_GPIOLIB only.
> >>
> >> Reading drivers/gpio/Kconfig confuses me a bit. I believe I should
> >> select ARCH_WANT_OPTIONAL_GPIOLIB, because the board can boot without
> >> GPIOs, they are needed for LEDs and buttons only. Also most users will
> >> want LEDs and buttons, so I "select GPIOLIB".
> >
> > Yes, my bad :)
> >
> > ARCH_REQUIRE_GPIOLIB selects GPIOLIB.
> > ARCH_WANT_OPTIONAL_GPIOLIB make GPIOLIB user selectable, so, in any
> > case you need to add ARCH_WANT_OPTIONAL_GPIOLIB only.
>
> So is there any way to make GPIOLIB optional (by using
> ARCH_WANT_OPTIONAL_GPIOLIB) and make it enabled by default? I wish
> GPIOLIB to be enabled by default as 99% users will want it.
Not so elegant, but you can select GPIOLIB for particular boards, which contain GPIO
functionality. I add Linus Walleij to CC for possible comments on this.
---
next prev parent reply other threads:[~2014-09-20 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 16:41 [PATCH] ARM: BCM5301X: select GPIOLIB as optional Rafał Miłecki
2014-09-20 17:00 ` Alexander Shiyan
2014-09-20 20:00 ` Rafał Miłecki
2014-09-20 20:14 ` Alexander Shiyan
2014-09-20 20:23 ` Rafał Miłecki
2014-09-20 20:30 ` Alexander Shiyan [this message]
2014-09-21 14:07 ` [PATCH V2] " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411245022.509392841@f140.i.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox