From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: koelsch: Move cec_clock to root node
Date: Thu, 02 Nov 2017 19:39:18 +0200 [thread overview]
Message-ID: <14112514.nMv28tbzn2@avalon> (raw)
In-Reply-To: <20171102091805.24967-1-horms+renesas@verge.net.au>
Hi Simon,
Thank you for the patch.
On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:
> cec-clock is a fixed clock generator that is not controlled by i2c5 and
> thus should not be a child of the i2c5 bus node. Rather, it should be
> a child of the root node of the DT.
>
> Fixes: 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI
> transmitter") Reported-by: Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index e164eda69baf..4126de417922
> 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -278,6 +278,12 @@
> };
> };
>
> + cec_clock: cec-clock {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <12000000>;
> + };
> +
> hdmi-out {
> compatible = "hdmi-connector";
> type = "a";
> @@ -640,12 +646,6 @@
> };
> };
>
> - cec_clock: cec-clock {
> - compatible = "fixed-clock";
> - #clock-cells = <0>;
> - clock-frequency = <12000000>;
> - };
> -
> hdmi at 39 {
> compatible = "adi,adv7511w";
> reg = <0x39>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-11-02 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 9:18 [PATCH] ARM: dts: koelsch: Move cec_clock to root node Simon Horman
2017-11-02 17:39 ` Laurent Pinchart [this message]
2017-11-03 8:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14112514.nMv28tbzn2@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox