linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andreas.henriksson@endian.se (Andreas Henriksson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
Date: Tue, 23 Sep 2014 17:12:52 +0200	[thread overview]
Message-ID: <1411485172-7984-1-git-send-email-andreas.henriksson@endian.se> (raw)
In-Reply-To: <5421623D.6090609@atmel.com>

As discovered on a custom board similar to at91sam9263ek and basing
its devicetree on that one apparently the pin muxing doesn't get
set up properly. This was discovered since the custom boards u-boot
does funky stuff with the pin muxing and leaved it set to SPI
which made the MMC driver not work under Linux.
The fix is simply to define the given configuration as the default.
This probably worked by pure luck before, but it's better to
make the muxing explicitly set.

CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
---
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 1 file changed, 2 insertions(+)

v2: put pinctrl-names in dtsi instead as requested/suggested by Nicolas Ferre


diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
index bb23c2d..5e95a80 100644
--- a/arch/arm/boot/dts/at91sam9263.dtsi
+++ b/arch/arm/boot/dts/at91sam9263.dtsi
@@ -834,6 +834,7 @@
 				compatible = "atmel,hsmci";
 				reg = <0xfff80000 0x600>;
 				interrupts = <10 IRQ_TYPE_LEVEL_HIGH 0>;
+				pinctrl-names = "default";
 				#address-cells = <1>;
 				#size-cells = <0>;
 				clocks = <&mci0_clk>;
@@ -845,6 +846,7 @@
 				compatible = "atmel,hsmci";
 				reg = <0xfff84000 0x600>;
 				interrupts = <11 IRQ_TYPE_LEVEL_HIGH 0>;
+				pinctrl-names = "default";
 				#address-cells = <1>;
 				#size-cells = <0>;
 				clocks = <&mci1_clk>;
-- 
2.1.0

  reply	other threads:[~2014-09-23 15:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 11:42 [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings Andreas Henriksson
2014-09-23 11:47 ` Boris BREZILLON
2014-09-23 12:06 ` Nicolas Ferre
2014-09-23 15:12   ` Andreas Henriksson [this message]
2014-09-23 15:43     ` [PATCH v2] " Boris BREZILLON
2014-09-24 16:11     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411485172-7984-1-git-send-email-andreas.henriksson@endian.se \
    --to=andreas.henriksson@endian.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).