* [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
@ 2014-09-23 11:42 Andreas Henriksson
2014-09-23 11:47 ` Boris BREZILLON
2014-09-23 12:06 ` Nicolas Ferre
0 siblings, 2 replies; 6+ messages in thread
From: Andreas Henriksson @ 2014-09-23 11:42 UTC (permalink / raw)
To: linux-arm-kernel
As discovered on a custom board similar to at91sam9263ek and basing
its devicetree on that one apparently the pin muxing doesn't get
set up properly. This was discovered since the custom boards u-boot
does funky stuff with the pin muxing and leaved it set to SPI
which made the MMC driver not work under Linux.
The fix is simply to define the given configuration as the default.
This probably worked by pure luck before, but it's better to
make the muxing explicitly set.
CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
---
arch/arm/boot/dts/at91sam9263ek.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts
index 5cf93ee..33a4f9a 100644
--- a/arch/arm/boot/dts/at91sam9263ek.dts
+++ b/arch/arm/boot/dts/at91sam9263ek.dts
@@ -64,6 +64,7 @@
};
mmc0: mmc at fff80000 {
+ pinctrl-names = "default";
pinctrl-0 = <
&pinctrl_board_mmc0
&pinctrl_mmc0_clk
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
2014-09-23 11:42 [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings Andreas Henriksson
@ 2014-09-23 11:47 ` Boris BREZILLON
2014-09-23 12:06 ` Nicolas Ferre
1 sibling, 0 replies; 6+ messages in thread
From: Boris BREZILLON @ 2014-09-23 11:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andreas,
On Tue, 23 Sep 2014 13:42:44 +0200
Andreas Henriksson <andreas.henriksson@endian.se> wrote:
> As discovered on a custom board similar to at91sam9263ek and basing
> its devicetree on that one apparently the pin muxing doesn't get
> set up properly. This was discovered since the custom boards u-boot
> does funky stuff with the pin muxing and leaved it set to SPI
> which made the MMC driver not work under Linux.
> The fix is simply to define the given configuration as the default.
> This probably worked by pure luck before, but it's better to
> make the muxing explicitly set.
>
> CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Thanks,
Boris
> ---
> arch/arm/boot/dts/at91sam9263ek.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts
> index 5cf93ee..33a4f9a 100644
> --- a/arch/arm/boot/dts/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/at91sam9263ek.dts
> @@ -64,6 +64,7 @@
> };
>
> mmc0: mmc at fff80000 {
> + pinctrl-names = "default";
> pinctrl-0 = <
> &pinctrl_board_mmc0
> &pinctrl_mmc0_clk
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
2014-09-23 11:42 [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings Andreas Henriksson
2014-09-23 11:47 ` Boris BREZILLON
@ 2014-09-23 12:06 ` Nicolas Ferre
2014-09-23 15:12 ` [PATCH v2] " Andreas Henriksson
1 sibling, 1 reply; 6+ messages in thread
From: Nicolas Ferre @ 2014-09-23 12:06 UTC (permalink / raw)
To: linux-arm-kernel
On 23/09/2014 13:42, Andreas Henriksson :
> As discovered on a custom board similar to at91sam9263ek and basing
> its devicetree on that one apparently the pin muxing doesn't get
> set up properly. This was discovered since the custom boards u-boot
> does funky stuff with the pin muxing and leaved it set to SPI
> which made the MMC driver not work under Linux.
> The fix is simply to define the given configuration as the default.
> This probably worked by pure luck before, but it's better to
> make the muxing explicitly set.
>
> CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
Thanks a lot for having fix this Andreas.
> ---
> arch/arm/boot/dts/at91sam9263ek.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts
> index 5cf93ee..33a4f9a 100644
> --- a/arch/arm/boot/dts/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/at91sam9263ek.dts
> @@ -64,6 +64,7 @@
> };
>
> mmc0: mmc at fff80000 {
> + pinctrl-names = "default";
On AT91, we tend to have this property directly in the SoC .dtsi file:
can you please add this "default" name to the 2 mmc hosts in
at91sam9263.dtsi file?
Thanks, best regards.
> pinctrl-0 = <
> &pinctrl_board_mmc0
> &pinctrl_mmc0_clk
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
2014-09-23 12:06 ` Nicolas Ferre
@ 2014-09-23 15:12 ` Andreas Henriksson
2014-09-23 15:43 ` Boris BREZILLON
2014-09-24 16:11 ` Nicolas Ferre
0 siblings, 2 replies; 6+ messages in thread
From: Andreas Henriksson @ 2014-09-23 15:12 UTC (permalink / raw)
To: linux-arm-kernel
As discovered on a custom board similar to at91sam9263ek and basing
its devicetree on that one apparently the pin muxing doesn't get
set up properly. This was discovered since the custom boards u-boot
does funky stuff with the pin muxing and leaved it set to SPI
which made the MMC driver not work under Linux.
The fix is simply to define the given configuration as the default.
This probably worked by pure luck before, but it's better to
make the muxing explicitly set.
CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
---
arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
1 file changed, 2 insertions(+)
v2: put pinctrl-names in dtsi instead as requested/suggested by Nicolas Ferre
diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
index bb23c2d..5e95a80 100644
--- a/arch/arm/boot/dts/at91sam9263.dtsi
+++ b/arch/arm/boot/dts/at91sam9263.dtsi
@@ -834,6 +834,7 @@
compatible = "atmel,hsmci";
reg = <0xfff80000 0x600>;
interrupts = <10 IRQ_TYPE_LEVEL_HIGH 0>;
+ pinctrl-names = "default";
#address-cells = <1>;
#size-cells = <0>;
clocks = <&mci0_clk>;
@@ -845,6 +846,7 @@
compatible = "atmel,hsmci";
reg = <0xfff84000 0x600>;
interrupts = <11 IRQ_TYPE_LEVEL_HIGH 0>;
+ pinctrl-names = "default";
#address-cells = <1>;
#size-cells = <0>;
clocks = <&mci1_clk>;
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
2014-09-23 15:12 ` [PATCH v2] " Andreas Henriksson
@ 2014-09-23 15:43 ` Boris BREZILLON
2014-09-24 16:11 ` Nicolas Ferre
1 sibling, 0 replies; 6+ messages in thread
From: Boris BREZILLON @ 2014-09-23 15:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 23 Sep 2014 17:12:52 +0200
Andreas Henriksson <andreas.henriksson@endian.se> wrote:
> As discovered on a custom board similar to at91sam9263ek and basing
> its devicetree on that one apparently the pin muxing doesn't get
> set up properly. This was discovered since the custom boards u-boot
> does funky stuff with the pin muxing and leaved it set to SPI
> which made the MMC driver not work under Linux.
> The fix is simply to define the given configuration as the default.
> This probably worked by pure luck before, but it's better to
> make the muxing explicitly set.
>
> CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> v2: put pinctrl-names in dtsi instead as requested/suggested by Nicolas Ferre
>
>
> diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> index bb23c2d..5e95a80 100644
> --- a/arch/arm/boot/dts/at91sam9263.dtsi
> +++ b/arch/arm/boot/dts/at91sam9263.dtsi
> @@ -834,6 +834,7 @@
> compatible = "atmel,hsmci";
> reg = <0xfff80000 0x600>;
> interrupts = <10 IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> #address-cells = <1>;
> #size-cells = <0>;
> clocks = <&mci0_clk>;
> @@ -845,6 +846,7 @@
> compatible = "atmel,hsmci";
> reg = <0xfff84000 0x600>;
> interrupts = <11 IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> #address-cells = <1>;
> #size-cells = <0>;
> clocks = <&mci1_clk>;
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
2014-09-23 15:12 ` [PATCH v2] " Andreas Henriksson
2014-09-23 15:43 ` Boris BREZILLON
@ 2014-09-24 16:11 ` Nicolas Ferre
1 sibling, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2014-09-24 16:11 UTC (permalink / raw)
To: linux-arm-kernel
On 23/09/2014 17:12, Andreas Henriksson :
> As discovered on a custom board similar to at91sam9263ek and basing
> its devicetree on that one apparently the pin muxing doesn't get
> set up properly. This was discovered since the custom boards u-boot
> does funky stuff with the pin muxing and leaved it set to SPI
> which made the MMC driver not work under Linux.
> The fix is simply to define the given configuration as the default.
> This probably worked by pure luck before, but it's better to
> make the muxing explicitly set.
>
> CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>
Thanks, I stacked it on at91-3.18-fixes-non-critical branch.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
For the record, we chose to set this
pinctrl-names = "default";
property in the SoC file without the associated pinctrl-0 property
because there is not "default" setting: we never know if we would use
the slot A or slot B with different pins in play.
So, as we must add a pinctrl-0 property in the board anyway, we decided
to not add pinctrl-0 in the SoC while keeping pinctrl-names as it is
always needed (as you experienced the hard way ;-)).
Best regards,
> ---
> arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> v2: put pinctrl-names in dtsi instead as requested/suggested by Nicolas Ferre
>
>
> diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> index bb23c2d..5e95a80 100644
> --- a/arch/arm/boot/dts/at91sam9263.dtsi
> +++ b/arch/arm/boot/dts/at91sam9263.dtsi
> @@ -834,6 +834,7 @@
> compatible = "atmel,hsmci";
> reg = <0xfff80000 0x600>;
> interrupts = <10 IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> #address-cells = <1>;
> #size-cells = <0>;
> clocks = <&mci0_clk>;
> @@ -845,6 +846,7 @@
> compatible = "atmel,hsmci";
> reg = <0xfff84000 0x600>;
> interrupts = <11 IRQ_TYPE_LEVEL_HIGH 0>;
> + pinctrl-names = "default";
> #address-cells = <1>;
> #size-cells = <0>;
> clocks = <&mci1_clk>;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-24 16:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 11:42 [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings Andreas Henriksson
2014-09-23 11:47 ` Boris BREZILLON
2014-09-23 12:06 ` Nicolas Ferre
2014-09-23 15:12 ` [PATCH v2] " Andreas Henriksson
2014-09-23 15:43 ` Boris BREZILLON
2014-09-24 16:11 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).