[PATCH] ARM: efm32: drop selecting NO_DMA

[PATCH] ARM: efm32: drop selecting NO_DMA

[Paul Bolle]

The Kconfig entry for ARCH_EFM32 selects NO_DMA. But that doesn't have
any effect as arm doesn't have a Kconfig entry for NO_DMA. This select
is a nop. Drop it.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested by playing with arch/arm/configs/efm32_defconfig. After "make
oldconfig" the .config contains CONFIG_HAS_DMA=y both before and after
this patch, as is expected.

Actually, the only difference I found in the .config file was that after
this patch the .config file contained
    CONFIG_ARCH_EFM32=y

I have no idea why. Did I botch my test?

 arch/arm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index d63e50615e9c..804ddc134c3c 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -426,7 +426,6 @@ config ARCH_EFM32
 	select COMMON_CLK
 	select CPU_V7M
 	select GENERIC_CLOCKEVENTS
-	select NO_DMA
 	select NO_IOPORT_MAP
 	select SPARSE_IRQ
 	select USE_OF
-- 
1.9.3

[PATCH] ARM: efm32: drop selecting NO_DMA

[Paul Bolle]

On Wed, 2014-09-24 at 20:59 +0200, Paul Bolle wrote:
> Actually, the only difference I found in the .config file was that after
> this patch the .config file contained
>     CONFIG_ARCH_EFM32=y
> 
> I have no idea why. Did I botch my test?

Apparently I did. I retested this patch using next-20140925. Now the
generated .config before and after applying this patch are identical. So
all's good: this select really is a nop.


Paul Bolle

[PATCH] ARM: efm32: drop selecting NO_DMA

[Uwe Kleine-König]

Hello Paul,

On Thu, Sep 25, 2014 at 12:14:16PM +0200, Paul Bolle wrote:
> On Wed, 2014-09-24 at 20:59 +0200, Paul Bolle wrote:
> > Actually, the only difference I found in the .config file was that after
> > this patch the .config file contained
> >     CONFIG_ARCH_EFM32=y
> > 
> > I have no idea why. Did I botch my test?
Looking at the patch that introduced the NO_DMA select I think I just
copied it from somewhere[1] without questioning it. It seems the symbol
already didn't exist when efm32 hit mainline in
6d85e2b0b6bed6ae7070426d5e43174c593e075c.

Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

[1] probably Catalin's 2.6.33 that introduced v7-M support initially.

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |