* [PATCH RESEND] tty: serial: omap: Remove probe error message
@ 2014-09-29 7:29 Markus Pargmann
2014-09-29 14:03 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Markus Pargmann @ 2014-09-29 7:29 UTC (permalink / raw)
To: linux-arm-kernel
This error message is not necessary. The driver core code will print all
probe error messages. It also resolves some error codes to proper error
messages. For example -EPROBE_DEFER will only be printed as an info message.
This patch removes the error message as the core prints the same
information.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
Hi,
I am not sure if this patch got lost, so I resend it. I rebased the patch onto
v3.17-rc1 without conflicts.
Best regards,
Markus
drivers/tty/serial/omap-serial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index d017cec8a34a..a153bad142c8 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1733,8 +1733,6 @@ err_add_port:
pm_runtime_disable(&pdev->dev);
err_rs485:
err_port_line:
- dev_err(&pdev->dev, "[UART%d]: failure [%s]: %d\n",
- pdev->id, __func__, ret);
return ret;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH RESEND] tty: serial: omap: Remove probe error message
2014-09-29 7:29 [PATCH RESEND] tty: serial: omap: Remove probe error message Markus Pargmann
@ 2014-09-29 14:03 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2014-09-29 14:03 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 29, 2014 at 09:29:42AM +0200, Markus Pargmann wrote:
> This error message is not necessary. The driver core code will print all
> probe error messages. It also resolves some error codes to proper error
> messages. For example -EPROBE_DEFER will only be printed as an info message.
>
> This patch removes the error message as the core prints the same
> information.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
fine by me:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140929/eeeb0b69/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH RESEND] tty: serial: omap: Remove probe error message
@ 2014-11-05 12:20 Markus Pargmann
0 siblings, 0 replies; 3+ messages in thread
From: Markus Pargmann @ 2014-11-05 12:20 UTC (permalink / raw)
To: linux-arm-kernel
This error message is not necessary. The driver core code will print all
probe error messages. It also resolves some error codes to proper error
messages. For example -EPROBE_DEFER will only be printed as an info message.
This patch removes the error message as the core prints the same
information.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Felipe Balbi <balbi@ti.com>
---
Hi,
this is another resend of this patch. I rebased it onto v3.18-rc3.
Regards,
Markus
drivers/tty/serial/omap-serial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 18c30cabe27f..6cda5cd8b513 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1747,8 +1747,6 @@ err_add_port:
pm_runtime_disable(&pdev->dev);
err_rs485:
err_port_line:
- dev_err(&pdev->dev, "[UART%d]: failure [%s]: %d\n",
- pdev->id, __func__, ret);
return ret;
}
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-05 12:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-29 7:29 [PATCH RESEND] tty: serial: omap: Remove probe error message Markus Pargmann
2014-09-29 14:03 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2014-11-05 12:20 Markus Pargmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).