* [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P
@ 2014-10-06 9:10 Paul Bolle
2014-10-06 9:26 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2014-10-06 9:10 UTC (permalink / raw)
To: linux-arm-kernel
Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
removed the Kconfig symbol PLAT_S5P. Remove an optional dependency on
that symbol from this Kconfig file too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
drivers/media/platform/s5p-tv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-tv/Kconfig b/drivers/media/platform/s5p-tv/Kconfig
index a9d56f8936b4..3d11fea5cc92 100644
--- a/drivers/media/platform/s5p-tv/Kconfig
+++ b/drivers/media/platform/s5p-tv/Kconfig
@@ -9,7 +9,7 @@
config VIDEO_SAMSUNG_S5P_TV
bool "Samsung TV driver for S5P platform"
depends on PM_RUNTIME
- depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
+ depends on ARCH_EXYNOS || COMPILE_TEST
default n
---help---
Say Y here to enable selecting the TV output devices for
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P
2014-10-06 9:10 [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P Paul Bolle
@ 2014-10-06 9:26 ` Arnd Bergmann
2014-10-06 9:34 ` Sylwester Nawrocki
2014-10-06 9:35 ` Paul Bolle
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2014-10-06 9:26 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 06 October 2014 11:10:26 Paul Bolle wrote:
> config VIDEO_SAMSUNG_S5P_TV
> bool "Samsung TV driver for S5P platform"
> depends on PM_RUNTIME
> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> + depends on ARCH_EXYNOS || COMPILE_TEST
> default n
> ---help---
> Say Y here to enable selecting the TV output devices for
>
I wonder if it should now allow being built for ARCH_S5PV210.
Maybe it was a mistake to remove the PLAT_S5P symbol without changing
the use here?
Does S5PV210 have this device?
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P
2014-10-06 9:26 ` Arnd Bergmann
@ 2014-10-06 9:34 ` Sylwester Nawrocki
2014-10-06 9:38 ` Paul Bolle
2014-10-06 9:35 ` Paul Bolle
1 sibling, 1 reply; 5+ messages in thread
From: Sylwester Nawrocki @ 2014-10-06 9:34 UTC (permalink / raw)
To: linux-arm-kernel
On 06/10/14 11:26, Arnd Bergmann wrote:
> On Monday 06 October 2014 11:10:26 Paul Bolle wrote:
>> config VIDEO_SAMSUNG_S5P_TV
>> bool "Samsung TV driver for S5P platform"
>> depends on PM_RUNTIME
>> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>> default n
>> ---help---
>> Say Y here to enable selecting the TV output devices for
>>
>
> I wonder if it should now allow being built for ARCH_S5PV210.
> Maybe it was a mistake to remove the PLAT_S5P symbol without changing
> the use here?
>
> Does S5PV210 have this device?
Yes, it does. Indeed, in all patches in this series we should
have replaced PLAT_S5P with ARCH_S5PV210.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P
2014-10-06 9:34 ` Sylwester Nawrocki
@ 2014-10-06 9:38 ` Paul Bolle
0 siblings, 0 replies; 5+ messages in thread
From: Paul Bolle @ 2014-10-06 9:38 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2014-10-06 at 11:34 +0200, Sylwester Nawrocki wrote:
> On 06/10/14 11:26, Arnd Bergmann wrote:
> >
> > Does S5PV210 have this device?
>
> Yes, it does. Indeed, in all patches in this series we should
> have replaced PLAT_S5P with ARCH_S5PV210.
If somebody would actually do that, that would be great. I lost patience
waiting for a patch that did that. So I submitted these cleanup patches
that basically change nothing.
Paul Bolle
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P
2014-10-06 9:26 ` Arnd Bergmann
2014-10-06 9:34 ` Sylwester Nawrocki
@ 2014-10-06 9:35 ` Paul Bolle
1 sibling, 0 replies; 5+ messages in thread
From: Paul Bolle @ 2014-10-06 9:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2014-10-06 at 11:26 +0200, Arnd Bergmann wrote:
> On Monday 06 October 2014 11:10:26 Paul Bolle wrote:
> > config VIDEO_SAMSUNG_S5P_TV
> > bool "Samsung TV driver for S5P platform"
> > depends on PM_RUNTIME
> > - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> > + depends on ARCH_EXYNOS || COMPILE_TEST
> > default n
> > ---help---
> > Say Y here to enable selecting the TV output devices for
> >
>
> I wonder if it should now allow being built for ARCH_S5PV210.
That was what Tomasz Figa claimed in
http://lkml.kernel.org/r/53C676DB.6070002 at samsung.com
> Maybe it was a mistake to remove the PLAT_S5P symbol without changing
> the use here?
At least it was a bit sloppy to remove the symbol without touching this
(and six other) dependencies. But after nearly three months I lost
patience waiting for a fix to be submitted.
My cleanup doesn't really change a thing. And a proper fix, if needed,
is still possible after this has landed.
> Does S5PV210 have this device?
Paul Bolle
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-06 9:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-06 9:10 [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P Paul Bolle
2014-10-06 9:26 ` Arnd Bergmann
2014-10-06 9:34 ` Sylwester Nawrocki
2014-10-06 9:38 ` Paul Bolle
2014-10-06 9:35 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).