* [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
2014-10-09 10:03 [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
@ 2014-10-09 10:03 ` Yoshihiro Kaneko
2014-10-09 12:27 ` Geert Uytterhoeven
2014-10-09 10:03 ` [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX " Yoshihiro Kaneko
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: Yoshihiro Kaneko @ 2014-10-09 10:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
include/dt-bindings/clock/r8a7790-clock.h | 1 +
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 2380fd5..27c038c 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -938,18 +938,19 @@
mstp1_clks: mstp1_clks at e6150134 {
compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150134 0 4>, <0 0xe6150038 0 4>;
- clocks = <&m2_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
+ clocks = <&m2_clk>, <&p_clk>, <&zg_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
<&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>,
<&zs_clk>;
#clock-cells = <1>;
renesas,clock-indices = <
- R8A7790_CLK_JPU R8A7790_CLK_TMU1 R8A7790_CLK_TMU3 R8A7790_CLK_TMU2
+ R8A7790_CLK_JPU R8A7790_CLK_TMU1 R8A7790_CLK_PVRSRVKM
+ R8A7790_CLK_TMU3 R8A7790_CLK_TMU2
R8A7790_CLK_CMT0 R8A7790_CLK_TMU0 R8A7790_CLK_VSP1_DU1
R8A7790_CLK_VSP1_DU0 R8A7790_CLK_VSP1_R R8A7790_CLK_VSP1_S
>;
clock-output-names =
- "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
- "vsp1-du0", "vsp1-rt", "vsp1-sy";
+ "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
+ "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
};
mstp2_clks: mstp2_clks at e6150138 {
compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h
index 8ea7ab0..2d2f668 100644
--- a/include/dt-bindings/clock/r8a7790-clock.h
+++ b/include/dt-bindings/clock/r8a7790-clock.h
@@ -28,6 +28,7 @@
/* MSTP1 */
#define R8A7790_CLK_JPU 6
#define R8A7790_CLK_TMU1 11
+#define R8A7790_CLK_PVRSRVKM 12
#define R8A7790_CLK_TMU3 21
#define R8A7790_CLK_TMU2 22
#define R8A7790_CLK_CMT0 24
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
2014-10-09 10:03 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
@ 2014-10-09 12:27 ` Geert Uytterhoeven
2014-10-10 1:26 ` Simon Horman
0 siblings, 1 reply; 14+ messages in thread
From: Geert Uytterhoeven @ 2014-10-09 12:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kaneko-san, Abe-san,
On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Kouei Abe <kouei.abe.cp@renesas.com>
Thanks for your patches!
> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
> include/dt-bindings/clock/r8a7790-clock.h | 1 +
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..27c038c 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> clock-output-names =
> - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
> - "vsp1-du0", "vsp1-rt", "vsp1-sy";
> + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
> + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
Why is this clock called "pvrsrvkm"?
The datasheet calls this clock "3DG".
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> +#define R8A7790_CLK_PVRSRVKM 12
Likewise.
My comments also apply to the corresponding patch for r8a7791.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
2014-10-09 12:27 ` Geert Uytterhoeven
@ 2014-10-10 1:26 ` Simon Horman
2014-10-20 0:53 ` Magnus Damm
0 siblings, 1 reply; 14+ messages in thread
From: Simon Horman @ 2014-10-10 1:26 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote:
> Hi Kaneko-san, Abe-san,
>
> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> > From: Kouei Abe <kouei.abe.cp@renesas.com>
>
> Thanks for your patches!
>
> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > ---
> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
> > include/dt-bindings/clock/r8a7790-clock.h | 1 +
> > 2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index 2380fd5..27c038c 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>
> > clock-output-names =
> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
> > - "vsp1-du0", "vsp1-rt", "vsp1-sy";
> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
>
> Why is this clock called "pvrsrvkm"?
> The datasheet calls this clock "3DG".
Good question.
I am of two minds on how to handle this:
1. Simply change the name to 3dg (simple)
2. Seek clarification from Abe-san and his team
Currently I am leaning to 1 as following the data-sheet feels like
the right thing to do.
Does anyone have an opinion on this?
> > --- a/include/dt-bindings/clock/r8a7790-clock.h
> > +++ b/include/dt-bindings/clock/r8a7790-clock.h
>
> > +#define R8A7790_CLK_PVRSRVKM 12
>
> Likewise.
>
> My comments also apply to the corresponding patch for r8a7791.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
2014-10-10 1:26 ` Simon Horman
@ 2014-10-20 0:53 ` Magnus Damm
2014-10-21 16:02 ` Simon Horman
2014-10-22 9:31 ` Kouei Abe
0 siblings, 2 replies; 14+ messages in thread
From: Magnus Damm @ 2014-10-20 0:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote:
>> Hi Kaneko-san, Abe-san,
>>
>> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> > From: Kouei Abe <kouei.abe.cp@renesas.com>
>>
>> Thanks for your patches!
>>
>> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
>> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> > ---
>> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
>> > include/dt-bindings/clock/r8a7790-clock.h | 1 +
>> > 2 files changed, 6 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> > index 2380fd5..27c038c 100644
>> > --- a/arch/arm/boot/dts/r8a7790.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>
>> > clock-output-names =
>> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
>> > - "vsp1-du0", "vsp1-rt", "vsp1-sy";
>> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
>> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
>>
>> Why is this clock called "pvrsrvkm"?
>> The datasheet calls this clock "3DG".
>
> Good question.
>
> I am of two minds on how to handle this:
>
> 1. Simply change the name to 3dg (simple)
> 2. Seek clarification from Abe-san and his team
>
> Currently I am leaning to 1 as following the data-sheet feels like
> the right thing to do.
>
> Does anyone have an opinion on this?
We are following the data sheet names everywhere else so I don't see
why this should be any exception. So my opinion is aligned with yours
- simply go with 1. above.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
2014-10-20 0:53 ` Magnus Damm
@ 2014-10-21 16:02 ` Simon Horman
2014-10-22 9:31 ` Kouei Abe
1 sibling, 0 replies; 14+ messages in thread
From: Simon Horman @ 2014-10-21 16:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 20, 2014 at 02:53:37AM +0200, Magnus Damm wrote:
> Hi Simon,
>
> On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote:
> >> Hi Kaneko-san, Abe-san,
> >>
> >> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> >> > From: Kouei Abe <kouei.abe.cp@renesas.com>
> >>
> >> Thanks for your patches!
> >>
> >> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> >> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> >> > ---
> >> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
> >> > include/dt-bindings/clock/r8a7790-clock.h | 1 +
> >> > 2 files changed, 6 insertions(+), 4 deletions(-)
> >> >
> >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> >> > index 2380fd5..27c038c 100644
> >> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> >>
> >> > clock-output-names =
> >> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
> >> > - "vsp1-du0", "vsp1-rt", "vsp1-sy";
> >> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
> >> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
> >>
> >> Why is this clock called "pvrsrvkm"?
> >> The datasheet calls this clock "3DG".
> >
> > Good question.
> >
> > I am of two minds on how to handle this:
> >
> > 1. Simply change the name to 3dg (simple)
> > 2. Seek clarification from Abe-san and his team
> >
> > Currently I am leaning to 1 as following the data-sheet feels like
> > the right thing to do.
> >
> > Does anyone have an opinion on this?
>
> We are following the data sheet names everywhere else so I don't see
> why this should be any exception. So my opinion is aligned with yours
> - simply go with 1. above.
Thanks. Kaneko-san has done so. And I have queued up the patches.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
2014-10-20 0:53 ` Magnus Damm
2014-10-21 16:02 ` Simon Horman
@ 2014-10-22 9:31 ` Kouei Abe
1 sibling, 0 replies; 14+ messages in thread
From: Kouei Abe @ 2014-10-22 9:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi Uytterhoeven-san, Magnus-san, Simon-san, Kaneko-san,
On Mon, 20 Oct 2014 02:53:37 +0200, Magnus Damm <magnus.damm@gmail.com> wrote:
| Hi Simon,
|
| On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman <horms@verge.net.au> wrote:
| > On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote:
| >> Hi Kaneko-san, Abe-san,
| >>
| >> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
| >> > From: Kouei Abe <kouei.abe.cp@renesas.com>
| >>
| >> Thanks for your patches!
| >>
| >> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
| >> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
| >> > ---
| >> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
| >> > include/dt-bindings/clock/r8a7790-clock.h | 1 +
| >> > 2 files changed, 6 insertions(+), 4 deletions(-)
| >> >
| >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
| >> > index 2380fd5..27c038c 100644
| >> > --- a/arch/arm/boot/dts/r8a7790.dtsi
| >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
| >>
| >> > clock-output-names =
| >> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
| >> > - "vsp1-du0", "vsp1-rt", "vsp1-sy";
| >> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
| >> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
| >>
| >> Why is this clock called "pvrsrvkm"?
| >> The datasheet calls this clock "3DG".
| >
| > Good question.
| >
| > I am of two minds on how to handle this:
| >
| > 1. Simply change the name to 3dg (simple)
| > 2. Seek clarification from Abe-san and his team
| >
| > Currently I am leaning to 1 as following the data-sheet feels like
| > the right thing to do.
| >
| > Does anyone have an opinion on this?
|
| We are following the data sheet names everywhere else so I don't see
| why this should be any exception. So my opinion is aligned with yours
| - simply go with 1. above.
|
| Cheers,
|
| / magnus
I confirmed that "pvrsrvkm" is 3DG driver's name.
So, I will agree "Simply change the name to 3dg (simple)" plan.
Kouei Abe
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX clock to device tree
2014-10-09 10:03 [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
@ 2014-10-09 10:03 ` Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Yoshihiro Kaneko
3 siblings, 0 replies; 14+ messages in thread
From: Yoshihiro Kaneko @ 2014-10-09 10:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm/boot/dts/r8a7791.dtsi | 11 ++++++-----
include/dt-bindings/clock/r8a7791-clock.h | 1 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index d343099..d59d2a8 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -1,7 +1,7 @@
/*
* Device Tree Source for the r8a7791 SoC
*
- * Copyright (C) 2013 Renesas Electronics Corporation
+ * Copyright (C) 2013-2014 Renesas Electronics Corporation
* Copyright (C) 2013-2014 Renesas Solutions Corp.
* Copyright (C) 2014 Cogent Embedded Inc.
*
@@ -947,17 +947,18 @@
mstp1_clks: mstp1_clks at e6150134 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150134 0 4>, <0 0xe6150038 0 4>;
- clocks = <&m2_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
+ clocks = <&m2_clk>, <&p_clk>, <&zg_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
<&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>;
#clock-cells = <1>;
renesas,clock-indices = <
- R8A7791_CLK_JPU R8A7791_CLK_TMU1 R8A7791_CLK_TMU3 R8A7791_CLK_TMU2
+ R8A7791_CLK_JPU R8A7791_CLK_TMU1 R8A7791_CLK_PVRSRVKM
+ R8A7791_CLK_TMU3 R8A7791_CLK_TMU2
R8A7791_CLK_CMT0 R8A7791_CLK_TMU0 R8A7791_CLK_VSP1_DU1
R8A7791_CLK_VSP1_DU0 R8A7791_CLK_VSP1_S
>;
clock-output-names =
- "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
- "vsp1-du0", "vsp1-sy";
+ "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
+ "vsp1-du1", "vsp1-du0", "vsp1-sy";
};
mstp2_clks: mstp2_clks at e6150138 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7791-clock.h b/include/dt-bindings/clock/r8a7791-clock.h
index 58c3f49..950250d 100644
--- a/include/dt-bindings/clock/r8a7791-clock.h
+++ b/include/dt-bindings/clock/r8a7791-clock.h
@@ -27,6 +27,7 @@
/* MSTP1 */
#define R8A7791_CLK_JPU 6
#define R8A7791_CLK_TMU1 11
+#define R8A7791_CLK_PVRSRVKM 12
#define R8A7791_CLK_TMU3 21
#define R8A7791_CLK_TMU2 22
#define R8A7791_CLK_CMT0 24
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP clock to device tree
2014-10-09 10:03 [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX " Yoshihiro Kaneko
@ 2014-10-09 10:03 ` Yoshihiro Kaneko
2014-10-09 12:29 ` Geert Uytterhoeven
2014-10-09 10:03 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Yoshihiro Kaneko
3 siblings, 1 reply; 14+ messages in thread
From: Yoshihiro Kaneko @ 2014-10-09 10:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 22 ++++++++++++++--------
include/dt-bindings/clock/r8a7790-clock.h | 11 ++++++++++-
2 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 27c038c..244a838 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -938,18 +938,24 @@
mstp1_clks: mstp1_clks at e6150134 {
compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150134 0 4>, <0 0xe6150038 0 4>;
- clocks = <&m2_clk>, <&p_clk>, <&zg_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
- <&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>,
- <&zs_clk>;
+ clocks = <&zs_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>, <&m2_clk>,
+ <&zs_clk>, <&p_clk>, <&zg_clk>, <&zs_clk>, <&zs_clk>,
+ <&zs_clk>, <&zs_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
+ <&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>;
#clock-cells = <1>;
renesas,clock-indices = <
- R8A7790_CLK_JPU R8A7790_CLK_TMU1 R8A7790_CLK_PVRSRVKM
- R8A7790_CLK_TMU3 R8A7790_CLK_TMU2
- R8A7790_CLK_CMT0 R8A7790_CLK_TMU0 R8A7790_CLK_VSP1_DU1
- R8A7790_CLK_VSP1_DU0 R8A7790_CLK_VSP1_R R8A7790_CLK_VSP1_S
+ R8A7790_CLK_VCP1 R8A7790_CLK_VCP0 R8A7790_CLK_VPC1
+ R8A7790_CLK_VPC0 R8A7790_CLK_JPU R8A7790_CLK_SSP1
+ R8A7790_CLK_TMU1 R8A7790_CLK_PVRSRVKM R8A7790_CLK_2DDMAC
+ R8A7790_CLK_FDP2 R8A7790_CLK_FDP1 R8A7790_CLK_FDP0
+ R8A7790_CLK_TMU3 R8A7790_CLK_TMU2 R8A7790_CLK_CMT0
+ R8A7790_CLK_TMU0 R8A7790_CLK_VSP1_DU1 R8A7790_CLK_VSP1_DU0
+ R8A7790_CLK_VSP1_R R8A7790_CLK_VSP1_S
>;
clock-output-names =
- "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
+ "vcp1", "vcp0", "vpc1", "vpc0", "jpu", "ssp1",
+ "tmu1", "pvrsrvkm", "2ddmac", "fdp2", "fdp1",
+ "fdp0", "tmu3", "tmu2", "cmt0", "tmu0",
"vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
};
mstp2_clks: mstp2_clks at e6150138 {
diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h
index 2d2f668..15ea834 100644
--- a/include/dt-bindings/clock/r8a7790-clock.h
+++ b/include/dt-bindings/clock/r8a7790-clock.h
@@ -26,9 +26,18 @@
#define R8A7790_CLK_MSIOF0 0
/* MSTP1 */
-#define R8A7790_CLK_JPU 6
+#define R8A7790_CLK_VCP1 0
+#define R8A7790_CLK_VCP0 1
+#define R8A7790_CLK_VPC1 2
+#define R8A7790_CLK_VPC0 3
+#define R8A7790_CLK_JPU 6
+#define R8A7790_CLK_SSP1 9
#define R8A7790_CLK_TMU1 11
#define R8A7790_CLK_PVRSRVKM 12
+#define R8A7790_CLK_2DDMAC 15
+#define R8A7790_CLK_FDP2 17
+#define R8A7790_CLK_FDP1 18
+#define R8A7790_CLK_FDP0 19
#define R8A7790_CLK_TMU3 21
#define R8A7790_CLK_TMU2 22
#define R8A7790_CLK_CMT0 24
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP clock to device tree
2014-10-09 10:03 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
@ 2014-10-09 12:29 ` Geert Uytterhoeven
2014-10-10 1:24 ` Simon Horman
0 siblings, 1 reply; 14+ messages in thread
From: Geert Uytterhoeven @ 2014-10-09 12:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kaneko-san, Hosoya-san,
On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Thanks for your patches!
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 22 ++++++++++++++--------
> include/dt-bindings/clock/r8a7790-clock.h | 11 ++++++++++-
> 2 files changed, 24 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 27c038c..244a838 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> clock-output-names =
> - "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
> + "vcp1", "vcp0", "vpc1", "vpc0", "jpu", "ssp1",
> + "tmu1", "pvrsrvkm", "2ddmac", "fdp2", "fdp1",
> + "fdp0", "tmu3", "tmu2", "cmt0", "tmu0",
The datasheet calls these clocks "fdp1-2", "fdp1-1", and "fdp1-0", instead
of "fdp2", "fdp1", and "fdp0".
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> +#define R8A7790_CLK_2DDMAC 15
> +#define R8A7790_CLK_FDP2 17
> +#define R8A7790_CLK_FDP1 18
> +#define R8A7790_CLK_FDP0 19
> #define R8A7790_CLK_TMU3 21
> #define R8A7790_CLK_TMU2 22
> #define R8A7790_CLK_CMT0 24
Likewise.
My comments also apply to the corresponding patch for r8a7791.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP clock to device tree
2014-10-09 12:29 ` Geert Uytterhoeven
@ 2014-10-10 1:24 ` Simon Horman
2014-10-10 2:46 ` Yoshihiro Kaneko
0 siblings, 1 reply; 14+ messages in thread
From: Simon Horman @ 2014-10-10 1:24 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 09, 2014 at 02:29:53PM +0200, Geert Uytterhoeven wrote:
> Hi Kaneko-san, Hosoya-san,
>
> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> > From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>
> Thanks for your patches!
>
> > Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > ---
> > arch/arm/boot/dts/r8a7790.dtsi | 22 ++++++++++++++--------
> > include/dt-bindings/clock/r8a7790-clock.h | 11 ++++++++++-
> > 2 files changed, 24 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index 27c038c..244a838 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>
> > clock-output-names =
> > - "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
> > + "vcp1", "vcp0", "vpc1", "vpc0", "jpu", "ssp1",
> > + "tmu1", "pvrsrvkm", "2ddmac", "fdp2", "fdp1",
> > + "fdp0", "tmu3", "tmu2", "cmt0", "tmu0",
>
> The datasheet calls these clocks "fdp1-2", "fdp1-1", and "fdp1-0", instead
> of "fdp2", "fdp1", and "fdp0".
Thanks.
Kaneko-san, can you update the patches accordingly?
> > --- a/include/dt-bindings/clock/r8a7790-clock.h
> > +++ b/include/dt-bindings/clock/r8a7790-clock.h
>
> > +#define R8A7790_CLK_2DDMAC 15
> > +#define R8A7790_CLK_FDP2 17
> > +#define R8A7790_CLK_FDP1 18
> > +#define R8A7790_CLK_FDP0 19
> > #define R8A7790_CLK_TMU3 21
> > #define R8A7790_CLK_TMU2 22
> > #define R8A7790_CLK_CMT0 24
>
> Likewise.
>
> My comments also apply to the corresponding patch for r8a7791.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP clock to device tree
2014-10-10 1:24 ` Simon Horman
@ 2014-10-10 2:46 ` Yoshihiro Kaneko
0 siblings, 0 replies; 14+ messages in thread
From: Yoshihiro Kaneko @ 2014-10-10 2:46 UTC (permalink / raw)
To: linux-arm-kernel
2014-10-10 10:24 GMT+09:00 Simon Horman <horms@verge.net.au>:
> On Thu, Oct 09, 2014 at 02:29:53PM +0200, Geert Uytterhoeven wrote:
>> Hi Kaneko-san, Hosoya-san,
>>
>> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> > From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>
>> Thanks for your patches!
>>
>> > Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> > ---
>> > arch/arm/boot/dts/r8a7790.dtsi | 22 ++++++++++++++--------
>> > include/dt-bindings/clock/r8a7790-clock.h | 11 ++++++++++-
>> > 2 files changed, 24 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> > index 27c038c..244a838 100644
>> > --- a/arch/arm/boot/dts/r8a7790.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>
>> > clock-output-names =
>> > - "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
>> > + "vcp1", "vcp0", "vpc1", "vpc0", "jpu", "ssp1",
>> > + "tmu1", "pvrsrvkm", "2ddmac", "fdp2", "fdp1",
>> > + "fdp0", "tmu3", "tmu2", "cmt0", "tmu0",
>>
>> The datasheet calls these clocks "fdp1-2", "fdp1-1", and "fdp1-0", instead
>> of "fdp2", "fdp1", and "fdp0".
>
> Thanks.
>
> Kaneko-san, can you update the patches accordingly?
Sure, I will do it.
>
>> > --- a/include/dt-bindings/clock/r8a7790-clock.h
>> > +++ b/include/dt-bindings/clock/r8a7790-clock.h
>>
>> > +#define R8A7790_CLK_2DDMAC 15
>> > +#define R8A7790_CLK_FDP2 17
>> > +#define R8A7790_CLK_FDP1 18
>> > +#define R8A7790_CLK_FDP0 19
>> > #define R8A7790_CLK_TMU3 21
>> > #define R8A7790_CLK_TMU2 22
>> > #define R8A7790_CLK_CMT0 24
>>
>> Likewise.
>>
>> My comments also apply to the corresponding patch for r8a7791.
>>
>> Gr{oetje,eeting}s,
>>
>> Geert
>>
>> --
>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>>
>> In personal conversations with technical people, I call myself a hacker. But
>> when I'm talking to journalists I just say "programmer" or something like that.
>> -- Linus Torvalds
>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/4] ARM: shmobile: r8a7791: Add MMP clock to device tree
2014-10-09 10:03 [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
` (2 preceding siblings ...)
2014-10-09 10:03 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
@ 2014-10-09 10:03 ` Yoshihiro Kaneko
3 siblings, 0 replies; 14+ messages in thread
From: Yoshihiro Kaneko @ 2014-10-09 10:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
arch/arm/boot/dts/r8a7791.dtsi | 21 +++++++++++++--------
include/dt-bindings/clock/r8a7791-clock.h | 8 +++++++-
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index d59d2a8..7a0ca37 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -947,18 +947,23 @@
mstp1_clks: mstp1_clks at e6150134 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150134 0 4>, <0 0xe6150038 0 4>;
- clocks = <&m2_clk>, <&p_clk>, <&zg_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
- <&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>;
+ clocks = <&zs_clk>, <&zs_clk>, <&m2_clk>, <&zs_clk>, <&p_clk>,
+ <&zg_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
+ <&p_clk>, <&rclk_clk>, <&cp_clk>, <&zs_clk>, <&zs_clk>,
+ <&zs_clk>;
#clock-cells = <1>;
renesas,clock-indices = <
- R8A7791_CLK_JPU R8A7791_CLK_TMU1 R8A7791_CLK_PVRSRVKM
- R8A7791_CLK_TMU3 R8A7791_CLK_TMU2
- R8A7791_CLK_CMT0 R8A7791_CLK_TMU0 R8A7791_CLK_VSP1_DU1
- R8A7791_CLK_VSP1_DU0 R8A7791_CLK_VSP1_S
+ R8A7791_CLK_VCP0 R8A7791_CLK_VPC0 R8A7791_CLK_JPU
+ R8A7791_CLK_SSP1 R8A7791_CLK_TMU1 R8A7791_CLK_PVRSRVKM
+ R8A7791_CLK_2DDMAC R8A7791_CLK_FDP1 R8A7791_CLK_FDP0
+ R8A7791_CLK_TMU3 R8A7791_CLK_TMU2 R8A7791_CLK_CMT0
+ R8A7791_CLK_TMU0 R8A7791_CLK_VSP1_DU1 R8A7791_CLK_VSP1_DU0
+ R8A7791_CLK_VSP1_S
>;
clock-output-names =
- "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
- "vsp1-du1", "vsp1-du0", "vsp1-sy";
+ "vcp0", "vpc0", "jpu", "ssp1", "tmu1", "pvrsrvkm",
+ "2ddmac", "fdp1", "fdp0", "tmu3", "tmu2", "cmt0",
+ "tmu0", "vsp1-du1", "vsp1-du0", "vsp1-sy";
};
mstp2_clks: mstp2_clks at e6150138 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7791-clock.h b/include/dt-bindings/clock/r8a7791-clock.h
index 950250d..4d1617e 100644
--- a/include/dt-bindings/clock/r8a7791-clock.h
+++ b/include/dt-bindings/clock/r8a7791-clock.h
@@ -25,9 +25,15 @@
#define R8A7791_CLK_MSIOF0 0
/* MSTP1 */
-#define R8A7791_CLK_JPU 6
+#define R8A7791_CLK_VCP0 1
+#define R8A7791_CLK_VPC0 3
+#define R8A7791_CLK_JPU 6
+#define R8A7791_CLK_SSP1 9
#define R8A7791_CLK_TMU1 11
#define R8A7791_CLK_PVRSRVKM 12
+#define R8A7791_CLK_2DDMAC 15
+#define R8A7791_CLK_FDP1 18
+#define R8A7791_CLK_FDP0 19
#define R8A7791_CLK_TMU3 21
#define R8A7791_CLK_TMU2 22
#define R8A7791_CLK_CMT0 24
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread