* [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
@ 2014-10-09 10:54 Riku Voipio
2014-10-09 14:00 ` Peter Oberparleiter
0 siblings, 1 reply; 6+ messages in thread
From: Riku Voipio @ 2014-10-09 10:54 UTC (permalink / raw)
To: linux-arm-kernel
Following up the arm testing of gcov, turns out gcov on ARM64
works fine as well. Only change needed is adding ARM64 to Kconfig
depends.
Tested with qemu and mach-virt
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
kernel/gcov/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index cf66c5c..3b74087 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov/Kconfig
@@ -35,7 +35,7 @@ config GCOV_KERNEL
config GCOV_PROFILE_ALL
bool "Profile entire Kernel"
depends on GCOV_KERNEL
- depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
+ depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
default n
---help---
This options activates profiling for the entire kernel.
--
2.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
2014-10-09 10:54 [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL Riku Voipio
@ 2014-10-09 14:00 ` Peter Oberparleiter
2014-10-14 21:40 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Peter Oberparleiter @ 2014-10-09 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Looks good. Andrew, can you pick this change up via your tree?
Acked-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
On 09.10.2014 12:54, Riku Voipio wrote:
> Following up the arm testing of gcov, turns out gcov on ARM64
> works fine as well. Only change needed is adding ARM64 to Kconfig
> depends.
>
> Tested with qemu and mach-virt
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> kernel/gcov/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> index cf66c5c..3b74087 100644
> --- a/kernel/gcov/Kconfig
> +++ b/kernel/gcov/Kconfig
> @@ -35,7 +35,7 @@ config GCOV_KERNEL
> config GCOV_PROFILE_ALL
> bool "Profile entire Kernel"
> depends on GCOV_KERNEL
> - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> default n
> ---help---
> This options activates profiling for the entire kernel.
>
--
Peter Oberparleiter
Linux on System z Development - IBM Germany
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
2014-10-09 14:00 ` Peter Oberparleiter
@ 2014-10-14 21:40 ` Andrew Morton
2014-10-14 21:54 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2014-10-14 21:40 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 09 Oct 2014 16:00:20 +0200 Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:
> Looks good. Andrew, can you pick this change up via your tree?
>
Sure.
>
> On 09.10.2014 12:54, Riku Voipio wrote:
> > Following up the arm testing of gcov, turns out gcov on ARM64
> > works fine as well. Only change needed is adding ARM64 to Kconfig
> > depends.
> >
> > Tested with qemu and mach-virt
> >
> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> > ---
> > kernel/gcov/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > index cf66c5c..3b74087 100644
> > --- a/kernel/gcov/Kconfig
> > +++ b/kernel/gcov/Kconfig
> > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> > config GCOV_PROFILE_ALL
> > bool "Profile entire Kernel"
> > depends on GCOV_KERNEL
> > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> > default n
> > ---help---
> > This options activates profiling for the entire kernel.
gcov is doing this the wrong way. There should be a `select
GCOV_PROFILE_ALL' in each arch/*/Kconfig.
(But pleeeeeeze not at the end of the list! That's the perfect way of
maximizing patch conflicts, but nobody seems to understand this)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
2014-10-14 21:40 ` Andrew Morton
@ 2014-10-14 21:54 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2014-10-14 21:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrew,
On Tue, 14 Oct 2014 14:40:48 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > > index cf66c5c..3b74087 100644
> > > --- a/kernel/gcov/Kconfig
> > > +++ b/kernel/gcov/Kconfig
> > > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> > > config GCOV_PROFILE_ALL
> > > bool "Profile entire Kernel"
> > > depends on GCOV_KERNEL
> > > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> > > default n
> > > ---help---
> > > This options activates profiling for the entire kernel.
>
> gcov is doing this the wrong way. There should be a `select
> GCOV_PROFILE_ALL' in each arch/*/Kconfig.
What they should actually do is select (say) ARCH_HAS_GCOV_PROFILE_ALL
and then GCOV_PROFILE_ALL should depend on that.
--
Cheers,
Stephen Rothwell sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141015/bc456ecb/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
@ 2014-10-16 13:46 Riku Voipio
2014-10-16 14:01 ` Riku Voipio
0 siblings, 1 reply; 6+ messages in thread
From: Riku Voipio @ 2014-10-16 13:46 UTC (permalink / raw)
To: linux-arm-kernel
Following up the arm testing of gcov, turns out gcov on ARM64
works fine as well. Only change needed is adding ARM64 to Kconfig
depends.
Tested with qemu and mach-virt
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
kernel/gcov/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index cf66c5c..3b74087 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov/Kconfig
@@ -35,7 +35,7 @@ config GCOV_KERNEL
config GCOV_PROFILE_ALL
bool "Profile entire Kernel"
depends on GCOV_KERNEL
- depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
+ depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
default n
---help---
This options activates profiling for the entire kernel.
--
2.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
2014-10-16 13:46 Riku Voipio
@ 2014-10-16 14:01 ` Riku Voipio
0 siblings, 0 replies; 6+ messages in thread
From: Riku Voipio @ 2014-10-16 14:01 UTC (permalink / raw)
To: linux-arm-kernel
On 16 October 2014 16:46, Riku Voipio <riku.voipio@linaro.org> wrote:
> Following up the arm testing of gcov, turns out gcov on ARM64
> works fine as well. Only change needed is adding ARM64 to Kconfig
> depends.
>
> Tested with qemu and mach-virt
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Sorry for the noise, this is the wrong patch. Will send the updated
one a moment.
Riku
> ---
> kernel/gcov/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> index cf66c5c..3b74087 100644
> --- a/kernel/gcov/Kconfig
> +++ b/kernel/gcov/Kconfig
> @@ -35,7 +35,7 @@ config GCOV_KERNEL
> config GCOV_PROFILE_ALL
> bool "Profile entire Kernel"
> depends on GCOV_KERNEL
> - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> default n
> ---help---
> This options activates profiling for the entire kernel.
> --
> 2.0.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-16 14:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-09 10:54 [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL Riku Voipio
2014-10-09 14:00 ` Peter Oberparleiter
2014-10-14 21:40 ` Andrew Morton
2014-10-14 21:54 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2014-10-16 13:46 Riku Voipio
2014-10-16 14:01 ` Riku Voipio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).