* [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable
@ 2014-10-14 20:01 Michael Spang
2014-10-20 16:10 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Michael Spang @ 2014-10-14 20:01 UTC (permalink / raw)
To: linux-arm-kernel
This enables the keyctl compat syscall.
Signed-off-by: Michael Spang <spang@chromium.org>
---
arch/arm64/Kconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index ac9afde..35c3103 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
source "security/Kconfig"
+config KEYS_COMPAT
+ bool
+ depends on COMPAT && KEYS
+ default y
+
source "crypto/Kconfig"
if CRYPTO
source "arch/arm64/crypto/Kconfig"
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable
2014-10-14 20:01 [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable Michael Spang
@ 2014-10-20 16:10 ` Will Deacon
2015-04-20 21:20 ` Michael Spang
0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2014-10-20 16:10 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 14, 2014 at 09:01:11PM +0100, Michael Spang wrote:
> This enables the keyctl compat syscall.
>
> Signed-off-by: Michael Spang <spang@chromium.org>
> ---
> arch/arm64/Kconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index ac9afde..35c3103 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
>
> source "security/Kconfig"
>
> +config KEYS_COMPAT
> + bool
> + depends on COMPAT && KEYS
> + default y
I'm curious as to why this requires a Kconfig option, whilst other compat
system calls do not. The core code is already using COMPAT_SYSCALL_DEFINE,
so why can't the architecture just plumb the compat syscall table and be
done with it?
Failing that, the pattern used elsewhere involves __ARCH_WANT_COMPAT_*
#defines.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable
2014-10-20 16:10 ` Will Deacon
@ 2015-04-20 21:20 ` Michael Spang
0 siblings, 0 replies; 3+ messages in thread
From: Michael Spang @ 2015-04-20 21:20 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 20, 2014 at 12:10 PM, Will Deacon <will.deacon@arm.com> wrote:
> On Tue, Oct 14, 2014 at 09:01:11PM +0100, Michael Spang wrote:
>> This enables the keyctl compat syscall.
>>
>> Signed-off-by: Michael Spang <spang@chromium.org>
>> ---
>> arch/arm64/Kconfig | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index ac9afde..35c3103 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
>>
>> source "security/Kconfig"
>>
>> +config KEYS_COMPAT
>> + bool
>> + depends on COMPAT && KEYS
>> + default y
>
> I'm curious as to why this requires a Kconfig option, whilst other compat
> system calls do not. The core code is already using COMPAT_SYSCALL_DEFINE,
> so why can't the architecture just plumb the compat syscall table and be
> done with it?
>
> Failing that, the pattern used elsewhere involves __ARCH_WANT_COMPAT_*
> #defines.
I am not actually sure why it is the way it is. All the other archs
just set the option exactly like this.
I've just resent it with only a minor adjustment.
Cheers!
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-20 21:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-14 20:01 [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable Michael Spang
2014-10-20 16:10 ` Will Deacon
2015-04-20 21:20 ` Michael Spang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).