From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: remove redundant irq disable at halt and restart
Date: Fri, 24 Oct 2014 21:06:32 +0200 [thread overview]
Message-ID: <1414177592-14547-1-git-send-email-johan@kernel.org> (raw)
Remove redundant local_irq_disable() at machine halt and restart.
Since commit 44424c34049f ("ARM: 7803/1: Fix deadlock scenario with
smp_send_stop()") interrupts are disabled before stopping secondary
CPUs.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
arch/arm/kernel/process.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index a35f6ebbd2c2..5663ab57cf07 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -195,7 +195,6 @@ void machine_halt(void)
local_irq_disable();
smp_send_stop();
- local_irq_disable();
while (1);
}
@@ -237,7 +236,6 @@ void machine_restart(char *cmd)
/* Whoops - the platform was unable to reboot. Tell the user! */
printk("Reboot failed -- System halted\n");
- local_irq_disable();
while (1);
}
--
2.0.4
next reply other threads:[~2014-10-24 19:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 19:06 Johan Hovold [this message]
2014-10-24 19:16 ` [PATCH] ARM: remove redundant irq disable at halt and restart Felipe Balbi
2014-10-24 19:21 ` Felipe Balbi
2014-10-24 19:28 ` Johan Hovold
2014-10-24 19:42 ` Felipe Balbi
2014-10-24 19:50 ` Johan Hovold
2014-10-24 20:07 ` Felipe Balbi
2014-11-26 15:13 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414177592-14547-1-git-send-email-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).