From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/9] arm: perf: add missing pr_info newlines
Date: Mon, 27 Oct 2014 12:06:32 +0000 [thread overview]
Message-ID: <1414411599-1938-3-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1414411599-1938-1-git-send-email-mark.rutland@arm.com>
Most of the pr_info format strings in perf_event_cpu.c are missing
newlines. Currently we get away with this as the format strings for
subsequent calls to printk (including all pr_* calls) begin with a log
prefix, and the printk core adds the omitted newline for this case.
While generates the output we expect, we probably should not rely on the
format of successive printk calls in order to get legible output.
This patch adds the missing newlines to pr_info format strings in
perf_event_cpu.c, making them consistent with the format strings for
other pr_info, warn, and pr_err calls, and preventing potentially
illegible output if the next printk/pr_* format string doesn't begin
with a log prefix.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
---
arch/arm/kernel/perf_event_cpu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c
index eb2c4d5..8e901f7 100644
--- a/arch/arm/kernel/perf_event_cpu.c
+++ b/arch/arm/kernel/perf_event_cpu.c
@@ -299,13 +299,13 @@ static int cpu_pmu_device_probe(struct platform_device *pdev)
int ret = -ENODEV;
if (cpu_pmu) {
- pr_info("attempt to register multiple PMU devices!");
+ pr_info("attempt to register multiple PMU devices!\n");
return -ENOSPC;
}
pmu = kzalloc(sizeof(struct arm_pmu), GFP_KERNEL);
if (!pmu) {
- pr_info("failed to allocate PMU device!");
+ pr_info("failed to allocate PMU device!\n");
return -ENOMEM;
}
@@ -320,7 +320,7 @@ static int cpu_pmu_device_probe(struct platform_device *pdev)
}
if (ret) {
- pr_info("failed to probe PMU!");
+ pr_info("failed to probe PMU!\n");
goto out_free;
}
@@ -331,7 +331,7 @@ static int cpu_pmu_device_probe(struct platform_device *pdev)
return 0;
out_free:
- pr_info("failed to register PMU devices!");
+ pr_info("failed to register PMU devices!\n");
kfree(pmu);
return ret;
}
--
1.9.1
next prev parent reply other threads:[~2014-10-27 12:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 12:06 [PATCHv2 0/9] Prepatory rework for multi-PMU support Mark Rutland
2014-10-27 12:06 ` [PATCHv2 1/9] arm: perf: factor out callchain code Mark Rutland
2014-10-27 12:06 ` Mark Rutland [this message]
2014-10-27 20:37 ` [PATCHv2 2/9] arm: perf: add missing pr_info newlines Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 3/9] arm: perf: make PMU probing data-driven Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 4/9] arm: perf: use IDR types for CPU PMUs Mark Rutland
2014-10-27 12:06 ` [PATCHv2 5/9] arm: perf: limit size of accounting data Mark Rutland
2014-10-27 21:13 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 6/9] arm: perf: kill get_hw_events() Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 7/9] arm: perf: fold percpu_pmu into pmu_hw_events Mark Rutland
2014-10-27 12:06 ` [PATCHv2 8/9] arm: perf: dynamically allocate cpu hardware data Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 9/9] arm: perf: fold hotplug notifier into arm_pmu Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-28 14:46 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414411599-1938-3-git-send-email-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).