* [PATCH] ARM: dts: imx6sx-sdb: Allow wakeup from buttons
@ 2014-10-29 20:25 Fabio Estevam
2014-11-03 6:21 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2014-10-29 20:25 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Allow the two button wakeup the system from low power mode.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx6sx-sdb.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
index 448489b..80ae281 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb.dts
@@ -39,12 +39,14 @@
volume-up {
label = "Volume Up";
gpios = <&gpio1 18 GPIO_ACTIVE_LOW>;
+ gpio-key,wakeup;
linux,code = <KEY_VOLUMEUP>;
};
volume-down {
label = "Volume Down";
gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
+ gpio-key,wakeup;
linux,code = <KEY_VOLUMEDOWN>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: dts: imx6sx-sdb: Allow wakeup from buttons
2014-10-29 20:25 [PATCH] ARM: dts: imx6sx-sdb: Allow wakeup from buttons Fabio Estevam
@ 2014-11-03 6:21 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2014-11-03 6:21 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 29, 2014 at 06:25:11PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Allow the two button wakeup the system from low power mode.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/boot/dts/imx6sx-sdb.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
> index 448489b..80ae281 100644
> --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> @@ -39,12 +39,14 @@
> volume-up {
> label = "Volume Up";
> gpios = <&gpio1 18 GPIO_ACTIVE_LOW>;
> + gpio-key,wakeup;
I can understand that this is convenient for developers, but I'm not
really sure if it's reasonable for users. IOW, is it expected that
volume keys can wake up system from low power mode? Or we should only
allow that from power key?
Shawn
> linux,code = <KEY_VOLUMEUP>;
> };
>
> volume-down {
> label = "Volume Down";
> gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
> + gpio-key,wakeup;
> linux,code = <KEY_VOLUMEDOWN>;
> };
> };
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-03 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-29 20:25 [PATCH] ARM: dts: imx6sx-sdb: Allow wakeup from buttons Fabio Estevam
2014-11-03 6:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).