linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mlangsdo@redhat.com (Mark Langsdorf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] [usb] make xhci platform driver use 64 bit or 32 bit DMA
Date: Thu, 30 Oct 2014 13:16:28 -0500	[thread overview]
Message-ID: <1414692989-23128-2-git-send-email-mlangsdo@redhat.com> (raw)
In-Reply-To: <1414692989-23128-1-git-send-email-mlangsdo@redhat.com>

The xhci platform driver needs to work on systems that either only
support 64-bit DMA or only support 32-bit DMA. Attempt to set a
coherent dma mask for 64-bit DMA, and attempt again with 32-bit
DMA if that fails.

Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
---
 drivers/usb/host/xhci-plat.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 1a0cf9f..3045e77 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -147,14 +147,17 @@ static int xhci_plat_probe(struct platform_device *pdev)
 			return ret;
 	}
 
-	/* Initialize dma_mask and coherent_dma_mask to 32-bits */
-	ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
-	if (ret)
-		return ret;
+	/* Try setting the coherent_dma_mask to 64 bits, then try 32 bits */
+	if (sizeof(dma_addr_t) < 8 ||
+		dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) {
+		ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
+		if (ret)
+			return ret;
+	}
 	if (!pdev->dev.dma_mask)
 		pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
 	else
-		dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
+		dma_set_mask(&pdev->dev, pdev->dev.coherent_dma_mask);
 
 	hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
 	if (!hcd)
-- 
1.9.3

  reply	other threads:[~2014-10-30 18:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 18:16 [usb] add support for APM X-Gene to xhci-platform Mark Langsdorf
2014-10-30 18:16 ` Mark Langsdorf [this message]
2014-10-30 19:05   ` [PATCH 1/2] [usb] make xhci platform driver use 64 bit or 32 bit DMA Arnd Bergmann
2014-10-30 20:09     ` Mark Langsdorf
2014-10-30 21:05       ` Arnd Bergmann
2014-10-31 14:22         ` Mark Langsdorf
2014-10-31 15:49           ` Arnd Bergmann
2014-10-31 17:32             ` Mark Langsdorf
2014-10-31 19:41               ` Arnd Bergmann
2014-11-03 14:15         ` Mark Salter
2014-11-03 17:14           ` Arnd Bergmann
2014-11-03 18:45             ` Mark Salter
2014-11-04 17:33             ` Al Stone
2014-11-06  0:03               ` Arnd Bergmann
2014-11-04 16:50   ` [PATCH v2 " Mark Langsdorf
2014-11-04 16:50     ` [PATCH v2 2/2] [usb] add support for ACPI identification to xhci-platform Mark Langsdorf
2014-11-04 17:12       ` Greg KH
2014-11-05 13:59         ` Mark Langsdorf
2014-11-05 19:11           ` Greg KH
2014-11-05 19:44             ` Mark Langsdorf
2014-11-05 19:55               ` Greg KH
2014-11-05 20:41                 ` Arnd Bergmann
2014-11-05 22:05                   ` Greg KH
2014-11-13 18:36         ` Mark Langsdorf
2014-11-13 19:08           ` Greg KH
2014-11-18 20:05           ` Feng Kan
2014-11-18 20:33             ` Mark Langsdorf
2014-11-18 21:11               ` Feng Kan
2014-10-30 18:16 ` [PATCH 2/2] [usb] add support for APM X-Gene " Mark Langsdorf
2014-10-30 19:07   ` Arnd Bergmann
2014-10-30 20:12     ` Mark Langsdorf
2014-10-30 20:53       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414692989-23128-2-git-send-email-mlangsdo@redhat.com \
    --to=mlangsdo@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).