From: eddie.huang@mediatek.com (eddie huang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] tty: serial: 8250_mtk: Fix quot calculation
Date: Mon, 3 Nov 2014 10:27:11 +0800 [thread overview]
Message-ID: <1414981632.23623.4.camel@mtksdaap41> (raw)
In-Reply-To: <9001280.dDNTE2ykLV@wuerfel>
On Fri, 2014-10-31 at 17:48 +0100, Arnd Bergmann wrote:
> On Friday 31 October 2014 17:36:35 Matthias Brugger wrote:
> > - quot = DIV_ROUND_CLOSEST(port->uartclk, 256 * baud);
> > + quot = (port->uartclk / (256 * baud)) + 1;
>
> Should this be DIV_ROUND_UP then?
>
> Arnd
>
I think DIV_ROUND_UP is more suitable in this case, and I already do
this and test OK on my MTK platform
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296149.html
prev parent reply other threads:[~2014-11-03 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 16:36 [PATCH RESEND] tty: serial: 8250_mtk: Fix quot calculation Matthias Brugger
2014-10-31 16:48 ` Arnd Bergmann
2014-11-03 2:27 ` eddie huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414981632.23623.4.camel@mtksdaap41 \
--to=eddie.huang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox