From mboxrd@z Thu Jan 1 00:00:00 1970 From: mpa@pengutronix.de (Markus Pargmann) Date: Mon, 3 Nov 2014 15:54:48 +0100 Subject: [PATCH v2 3/3] imx-drm: parallel-display: Fix dpms mode handling In-Reply-To: <1415026488-25309-1-git-send-email-mpa@pengutronix.de> References: <1415026488-25309-1-git-send-email-mpa@pengutronix.de> Message-ID: <1415026488-25309-4-git-send-email-mpa@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org We have to call drm_panel_prepare() and drm_panel_unprepare() when switching on or off. This patch also replaces the if statement with an switch statement to only catch ON and OFF modes. Signed-off-by: Markus Pargmann --- drivers/staging/imx-drm/parallel-display.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c index 0992bbf01adc..62788177c9d4 100644 --- a/drivers/staging/imx-drm/parallel-display.c +++ b/drivers/staging/imx-drm/parallel-display.c @@ -106,10 +106,18 @@ static void imx_pd_encoder_dpms(struct drm_encoder *encoder, int mode) { struct imx_parallel_display *imxpd = enc_to_imxpd(encoder); - if (mode != DRM_MODE_DPMS_ON) - drm_panel_disable(imxpd->panel); - else + switch (mode) { + case DRM_MODE_DPMS_ON: + drm_panel_prepare(imxpd->panel); drm_panel_enable(imxpd->panel); + break; + case DRM_MODE_DPMS_OFF: + drm_panel_disable(imxpd->panel); + drm_panel_unprepare(imxpd->panel); + break; + default: + break; + } } static bool imx_pd_encoder_mode_fixup(struct drm_encoder *encoder, -- 2.1.1