[PATCH] ARM: dts: imx6qdl-sabresd.dtsi: Fix the microphone route

[PATCH] ARM: dts: imx6qdl-sabresd.dtsi: Fix the microphone route

[Fabio Estevam]

Since commit e409dfbfccf9a49 ("ASoC: dapm: Add a few supply widget sanity 
checks") the following error is seen:

imx-wm8962 sound: wm8962 <-> 202c000.ssi mapping ok
imx-wm8962 sound: Connecting non-supply widget to supply widget is not supported (AMIC -> MICBIAS)
imx-wm8962 sound: ASoC: no dapm match for AMIC --> (null) --> MICBIAS
imx-wm8962 sound: ASoC: Failed to add route AMIC -> direct -> MICBIAS

Invert the route between the microphone and the bias in order to fix it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Shawn,

commit e409dfbfccf9a49 is not in your tree. It is in Mark's tree at the moment.

If you prefer I can skip mentioning it in the commit log.

The 'AMIC -> MICBIAS' route is also used on mx6sx-sdb and mx6sl-evk boards.

 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index d211d5d..d1319bd 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -107,7 +107,7 @@
 			"Headphone Jack", "HPOUTR",
 			"Ext Spk", "SPKOUTL",
 			"Ext Spk", "SPKOUTR",
-			"MICBIAS", "AMIC",
+			"AMIC", "MICBIAS",
 			"IN3R", "MICBIAS",
 			"DMIC", "MICBIAS",
 			"DMICDAT", "DMIC";
-- 
1.9.1

[PATCH] ARM: dts: imx6qdl-sabresd.dtsi: Fix the microphone route

[Shawn Guo]

On Tue, Nov 04, 2014 at 10:56:09AM -0200, Fabio Estevam wrote:
> Since commit e409dfbfccf9a49 ("ASoC: dapm: Add a few supply widget sanity 
> checks") the following error is seen:
> 
> imx-wm8962 sound: wm8962 <-> 202c000.ssi mapping ok
> imx-wm8962 sound: Connecting non-supply widget to supply widget is not supported (AMIC -> MICBIAS)
> imx-wm8962 sound: ASoC: no dapm match for AMIC --> (null) --> MICBIAS
> imx-wm8962 sound: ASoC: Failed to add route AMIC -> direct -> MICBIAS

Any regression behind that error message?

Shawn

> 
> Invert the route between the microphone and the bias in order to fix it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Shawn,
> 
> commit e409dfbfccf9a49 is not in your tree. It is in Mark's tree at the moment.
> 
> If you prefer I can skip mentioning it in the commit log.
> 
> The 'AMIC -> MICBIAS' route is also used on mx6sx-sdb and mx6sl-evk boards.
> 
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index d211d5d..d1319bd 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -107,7 +107,7 @@
>  			"Headphone Jack", "HPOUTR",
>  			"Ext Spk", "SPKOUTL",
>  			"Ext Spk", "SPKOUTR",
> -			"MICBIAS", "AMIC",
> +			"AMIC", "MICBIAS",
>  			"IN3R", "MICBIAS",
>  			"DMIC", "MICBIAS",
>  			"DMICDAT", "DMIC";
> -- 
> 1.9.1
> 

[PATCH] ARM: dts: imx6qdl-sabresd.dtsi: Fix the microphone route

[Fabio Estevam]

On Tue, Nov 4, 2014 at 11:08 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Tue, Nov 04, 2014 at 10:56:09AM -0200, Fabio Estevam wrote:
>> Since commit e409dfbfccf9a49 ("ASoC: dapm: Add a few supply widget sanity
>> checks") the following error is seen:
>>
>> imx-wm8962 sound: wm8962 <-> 202c000.ssi mapping ok
>> imx-wm8962 sound: Connecting non-supply widget to supply widget is not supported (AMIC -> MICBIAS)
>> imx-wm8962 sound: ASoC: no dapm match for AMIC --> (null) --> MICBIAS
>> imx-wm8962 sound: ASoC: Failed to add route AMIC -> direct -> MICBIAS
>
> Any regression behind that error message?

Playback works fine, but I am having issues with arecord with or
without this patch, so I haven't seen any regression.

Will investigate the arecord problem I am having (maybe it is a
alsamixer config issue).

[PATCH] ARM: dts: imx6qdl-sabresd.dtsi: Fix the microphone route

[Nicolin Chen]

On Wed, Nov 05, 2014 at 10:16:40AM -0200, Fabio Estevam wrote:
> On Tue, Nov 4, 2014 at 11:08 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > On Tue, Nov 04, 2014 at 10:56:09AM -0200, Fabio Estevam wrote:
> >> Since commit e409dfbfccf9a49 ("ASoC: dapm: Add a few supply widget sanity
> >> checks") the following error is seen:
> >>
> >> imx-wm8962 sound: wm8962 <-> 202c000.ssi mapping ok
> >> imx-wm8962 sound: Connecting non-supply widget to supply widget is not supported (AMIC -> MICBIAS)
> >> imx-wm8962 sound: ASoC: no dapm match for AMIC --> (null) --> MICBIAS
> >> imx-wm8962 sound: ASoC: Failed to add route AMIC -> direct -> MICBIAS
> >
> > Any regression behind that error message?
> 
> Playback works fine, but I am having issues with arecord with or
> without this patch, so I haven't seen any regression.
> 
> Will investigate the arecord problem I am having (maybe it is a
> alsamixer config issue).

I just took a test on imx6sx-sdb with the identical AMIC route
as SabreSD does, but the microphone actually still works even
if the same link error occurs.

So I think the error doesn't break the function on Sabre SD
either...and the reason should be the dts connecting 'IN3R'
directly to MICBIAS, which isn't so accurate.

For the patch, I think the configuration on imx6sx-sdb would
be better.

120                         "AMIC", "MICBIAS",
121                         "IN3R", "AMIC";

Thanks
Nicolin