From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] PM / Domains: Initial PM clock support for genpd
Date: Wed, 19 Nov 2014 15:00:36 +0100 [thread overview]
Message-ID: <1416405638-18812-2-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1416405638-18812-1-git-send-email-ulf.hansson@linaro.org>
It's quite common for PM domains to use PM clocks. Typically from SOC
specific code, the per device PM clock list is created and
pm_clk_suspend|resume() are invoked to handle clock gating/ungating.
A step towards consolidation is to integrate PM clock support into
genpd, which is what this patch does.
In this initial step, the calls to the pm_clk_suspend|resume() are
handled within genpd, but the per device PM clock list still needs to
be created from SOC specific code. It seems reasonable to have gendp to
handle that as well, but that left to future patches to address.
It's not every users of genpd that are keen on using PM clocks thus we
need to provide this a configuration option for genpd. Therefore let's
add flag field in the genpd struct to keep this information and define
a new PM_DOMAIN_PM_CLK bit can then be set at initialization.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/base/power/domain.c | 7 +++++++
include/linux/pm_domain.h | 3 +++
2 files changed, 10 insertions(+)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 3989eb6..42e328c 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -12,6 +12,7 @@
#include <linux/pm_runtime.h>
#include <linux/pm_domain.h>
#include <linux/pm_qos.h>
+#include <linux/pm_clock.h>
#include <linux/slab.h>
#include <linux/err.h>
#include <linux/sched.h>
@@ -1948,6 +1949,12 @@ void pm_genpd_init(struct generic_pm_domain *genpd,
genpd->domain.ops.complete = pm_genpd_complete;
genpd->dev_ops.save_state = pm_genpd_default_save_state;
genpd->dev_ops.restore_state = pm_genpd_default_restore_state;
+
+ if (genpd->flags & PM_DOMAIN_PM_CLK) {
+ genpd->dev_ops.stop = pm_clk_suspend;
+ genpd->dev_ops.start = pm_clk_suspend;
+ }
+
mutex_lock(&gpd_list_lock);
list_add(&genpd->gpd_list_node, &gpd_list);
mutex_unlock(&gpd_list_lock);
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index 9d254e2..44c6931 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -14,6 +14,7 @@
#include <linux/pm.h>
#include <linux/err.h>
#include <linux/of.h>
+#include <linux/bitops.h>
#include <linux/notifier.h>
#include <linux/cpuidle.h>
@@ -76,6 +77,8 @@ struct generic_pm_domain {
struct device *dev);
void (*detach_dev)(struct generic_pm_domain *domain,
struct device *dev);
+ unsigned int flags; /* Bit field of configs for genpd */
+#define PM_DOMAIN_PM_CLK BIT(0) /* PM domain use PM clk */
};
static inline struct generic_pm_domain *pd_to_genpd(struct dev_pm_domain *pd)
--
1.9.1
next prev parent reply other threads:[~2014-11-19 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:00 [PATCH 0/3] PM / Domains: Add initial PM clock support to genpd Ulf Hansson
2014-11-19 14:00 ` Ulf Hansson [this message]
2014-11-19 17:25 ` [PATCH 1/3] PM / Domains: Initial PM clock support for genpd Dmitry Torokhov
2014-11-20 11:53 ` Ulf Hansson
2014-11-19 14:00 ` [PATCH 2/3] ARM: shmobile: Convert to genpd flags for PM clocks for r8a7779 Ulf Hansson
2014-11-19 14:00 ` [PATCH 3/3] ARM: shmobile: Convert to genpd flags for PM clocks for R-mobile Ulf Hansson
2014-11-19 16:07 ` [PATCH 0/3] PM / Domains: Add initial PM clock support to genpd Geert Uytterhoeven
2014-11-20 0:33 ` Kevin Hilman
2014-11-20 10:23 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416405638-18812-2-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).