linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "mfd: tps65910: Convert ti, system-power-controller DT property to poweroff-source"
Date: Fri, 21 Nov 2014 12:00:16 +0100	[thread overview]
Message-ID: <1416567616-10582-1-git-send-email-johan@kernel.org> (raw)
In-Reply-To: <20141121105951.GA20679@localhost>

This reverts commit 25f833c1171d ("mfd: tps65910: Convert
ti,system-power-controller DT property to poweroff-source"), which
switched to a new device-tree property name for configuring the device
as a power-off controller, but failed to update the affected device-tree
sources and neither provided backward compatibility with the old
property name.

This fixes broken power-off functionality for all boards relying on
tps65910 to power off the system.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/mfd/tps65910.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index b8dca8a0db41..7612d89850dd 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -423,7 +423,8 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
 
 	board_info->irq = client->irq;
 	board_info->irq_base = -1;
-	board_info->pm_off = of_system_has_poweroff_source(np);
+	board_info->pm_off = of_property_read_bool(np,
+			"ti,system-power-controller");
 
 	return board_info;
 }
-- 
2.0.4

  reply	other threads:[~2014-11-21 11:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1415885699-1465-1-git-send-email-user@radxa>
     [not found] ` <1415885699-1465-2-git-send-email-user@radxa>
2014-11-13 20:55   ` [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller" Grant Likely
2014-11-14  7:22     ` Romain Perier
2014-11-17 10:51       ` Romain Perier
2014-11-20 10:44         ` Romain Perier
2014-11-21 10:59   ` Johan Hovold
2014-11-21 11:00     ` Johan Hovold [this message]
2014-11-21 13:18     ` Romain Perier
2014-11-21 13:22       ` Romain Perier
2014-11-24 10:24     ` Lee Jones
2014-11-24 11:35       ` Johan Hovold
2014-11-24 12:58         ` Romain Perier
2014-11-24 13:01           ` Romain Perier
2014-11-24 13:12             ` Heiko Stübner
2014-11-24 13:21           ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416567616-10582-1-git-send-email-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).