From: flora.fu@mediatek.com (Flora Fu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator
Date: Mon, 1 Dec 2014 11:19:25 +0800 [thread overview]
Message-ID: <1417403967.9547.2.camel@mtksdaap41> (raw)
In-Reply-To: <20141128153008.GS7712@sirena.org.uk>
Hi, Mark,
On Fri, 2014-11-28 at 15:30 +0000, Mark Brown wrote:
> On Fri, Nov 28, 2014 at 11:54:34AM +0800, Flora Fu wrote:
>
> > Add device tree for MT6397 regulators in mt8135.dtsi.
> >
> > Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> > ---
> > arch/arm/boot/dts/mt8135.dtsi | 192 ++++++++++++++++++++++++++++++++++++++++++
>
> This appears to be the DT fragment for a SoC but you are defining the
> system integration for the PMIC. That's bad, the PMIC is a separate
> device so should be hooked up by the board using it. If there's common
> elements from a reference design they should be in their own .dtsi.
>
Do you mean that we should add a mt6397.dtsi and include it from
mt8135.dtsi? For board specific, update them in mt8135.dtsi?
Thanks,
Flora
next prev parent reply other threads:[~2014-12-01 3:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 3:54 [PATCH v2 0/8] Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Flora Fu
2014-11-28 3:54 ` [PATCH v2 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC Flora Fu
2014-11-28 15:32 ` Mark Brown
2014-11-28 3:54 ` [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD Flora Fu
2014-12-01 11:47 ` Lee Jones
2014-12-03 8:40 ` Flora Fu
2014-12-03 9:26 ` Lee Jones
2014-11-28 3:54 ` [PATCH v2 3/8] regulator: MT6397: Add support for MT6397 regulator Flora Fu
2014-11-28 15:22 ` Mark Brown
2014-12-01 2:51 ` Flora Fu
2014-12-01 16:12 ` Mark Brown
2014-11-28 3:54 ` [PATCH v2 4/8] dt-bindings:: Add document for MT8135 PMIC Wrapper Flora Fu
2014-11-28 3:54 ` [PATCH v2 5/8] dt-bindings: Add document for MT6397 MFD Flora Fu
2014-11-28 3:54 ` [PATCH v2 6/8] dt-bindings: Add document for MT6397 regulator Flora Fu
2014-11-28 15:30 ` Mark Brown
2014-11-28 3:54 ` [PATCH v2 7/8] ARM: dts: mt8135: Add support for PMIC MT6397 MFD Flora Fu
2014-11-28 3:54 ` [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator Flora Fu
2014-11-28 15:30 ` Mark Brown
2014-12-01 3:19 ` Flora Fu [this message]
2014-12-01 6:40 ` Sascha Hauer
2014-12-01 11:16 ` Mark Brown
2014-12-01 7:04 ` [PATCH v2 0/8] Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417403967.9547.2.camel@mtksdaap41 \
--to=flora.fu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox