linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested
Date: Wed, 10 Dec 2014 17:19:26 +0800	[thread overview]
Message-ID: <1418203166.21309.3.camel@mtksdaap41> (raw)
In-Reply-To: <20141209165807.GJ31129@e104818-lin.cambridge.arm.com>

On Tue, 2014-12-09 at 16:58 +0000, Catalin Marinas wrote:
<...>
> You mix timer and counter terms here. Anyway, of we use physical timer,
> you could argue that it makes sense to use the corresponding physical
> counter (CNTPCT). However, on arm64 we only expose CNTVCT to user VDSO
> and we want to use the same in the kernel. When booting at EL2, CNTVCT
> == CNTPCT because we control CNTVOFF, that's unless we have some broken
> firmware that does not restore CNTVOFF correctly. That's what we want
> to spot early, hence the aim to always use the virtual counter (but not
> the timer, use use the physical timer as it makes it easier for KVM).
> 
> So the patch below, on top of linux-next, should solve the BUG():

Thanks for detail explanation and the patch. I tested it on my platform
and it did solve the issue. So,

Tested-by: Yingjoe Chen <yingjoe.chen@mediatek.com>

Joe.C

      reply	other threads:[~2014-12-10  9:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  7:02 [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested Sonny Rao
2014-11-24  9:01 ` Daniel Lezcano
2014-11-24 14:16   ` Catalin Marinas
2014-11-24 14:19     ` Daniel Lezcano
2014-11-26 12:47 ` Daniel Lezcano
2014-12-05  7:30 ` Olof Johansson
2014-12-05 10:41 ` Yingjoe Chen
2014-12-08 16:21   ` Catalin Marinas
2014-12-09  6:31     ` Yingjoe Chen
2014-12-09 16:58       ` Catalin Marinas
2014-12-10  9:19         ` Yingjoe Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418203166.21309.3.camel@mtksdaap41 \
    --to=yingjoe.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).