linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6
Date: Wed, 10 Dec 2014 11:26:00 +0100	[thread overview]
Message-ID: <1418207160.3258.4.camel@pengutronix.de> (raw)
In-Reply-To: <20141210050928.GB11802@shlinux2>

Hi Peter,

Am Mittwoch, den 10.12.2014, 13:09 +0800 schrieb Peter Chen:
> On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote:
> > On i.MX6Q, the USBMISC registers are clocked by the IPG clock,
> > so there is no need to enable USBOH3 for the USBMISC driver.
> 
> Access the registers at usbmisc needs the same clock with chipidea core,
> both are usboh3.

Alright, I'll drop this patch.

It was my understanding that the usbmisc register space is clocked by
ipg_clk_s, which is not gated by usboh3_clk_enable:
Having a look at the "i.MX 6Dual/6Quad Applications Processor Reference
Manual, Rev. 1, 04/2013", Figure 65-1 "USB block diagram" shows the USB
Control Register (usbmisc) directly connected via "IP Bus1" separately
from the host cores (these are connected behind a PL301).
In chapter 18.4 "System Clocks", the table entry for the block instance
"USB" shows that the usboh3_clk_enable bit gates only the ipg_ahb_clk,
ipg_clk_s_pl301, test_clk_240m, test_clk_480m, and test_clk_60m inputs
to the USB block. The ipg_clk_s (from ipg_clk_root) and ipg_clk_32khz
inputs are not marked as gated. Still, it seems that indeed the usbmisc
region is inaccessible after gating usboh3 by unbinding the usb drivers.

regards
Philipp

  reply	other threads:[~2014-12-10 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 16:13 [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6 Philipp Zabel
2014-12-09 16:13 ` [PATCH 2/2] ARM: dts: imx6qdl: remove USBOH3 clock from usbmisc, it is clocked by IPG Philipp Zabel
2014-12-10  5:09 ` [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6 Peter Chen
2014-12-10 10:26   ` Philipp Zabel [this message]
2014-12-10  7:46 ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418207160.3258.4.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).