From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 16 Dec 2014 21:19:05 +0100 Subject: [PATCHv1] rtc: bcm-iproc: Add support for Broadcom iproc rtc In-Reply-To: <54909074.2070804@broadcom.com> References: <1418757750-3628-1-git-send-email-arun.ramamurthy@broadcom.com> <7947905.aK8KkUx4sY@wuerfel> <54909074.2070804@broadcom.com> Message-ID: <1418783023.hzNZBNCmFc@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 16 December 2014 12:05:08 Arun Ramamurthy wrote: > On 14-12-16 11:42 AM, Arnd Bergmann wrote: > > On Tuesday 16 December 2014 11:22:30 arun.ramamurthy at broadcom.com wrote: > >> + rtc: iproc_rtc at 0x03026000 { > >> + compatible = "brcm,iproc-rtc"; > >> + reg = spru_bbl: <0x03026000 0xC>, > >> + crmu_pwr_good_status: <0x0301C02C 0x14>, > >> + crmu_bbl_auth: <0x03024C74 0x8>; > >> + interrupts = spru_rtc_periodic: , > >> + spru_alarm: ; > > > > The reg properties look really random, could it be that the registers > > are really part of some other device that contains multiple functions? > > > This RTC block is on a battery backed logic island and is accessed > indirectly using the spru_bbl registers. The CRMU registers are required > to read the power status and write to some authentication registers. > Without writing to these authentication > registers, we cannot access any of the spru_bbl registers. In conclusion > I don't think the CRMU register accesses can be considered as another > device access. Do you agree Arnd? It sounds like CRMU is some other unit aside from the RTC. Could this be something like a generic system controller? I think it should either have its own driver or use the syscon logic if that is what this is. > > Also, what do you use the labels for? > > > The labels are purely to improve readability of the device tree entry Please remove them then, they don't help at all. Arnd