From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: timer-atmel-pit: don't suspend/resume if unused
Date: Thu, 18 Dec 2014 15:05:23 +0100 [thread overview]
Message-ID: <1418911523-28492-1-git-send-email-nicolas.ferre@atmel.com> (raw)
From: Sylvain Rochet <sylvain.rochet@finsecur.com>
Waiting for PIT to stop counting takes a long time:
1/(Master clock/prescaler/PIVR)
= 1/(133 MHz /16 /2^20)
= 126 ms
Up to 126 ms if master clock is set to 133 MHz, skipping suspend/resume
of the unused PIT device reduce (suspend time + resume time) from ~140 ms
to ~17 ms.
Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
[nicolas.ferre at atmel.com: move to newer clocksource driver]
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
---
Hi Sylvain,
I re-worked (and "Acked") your patch so it can be applied on the newer Mainline
kernels. Beware, I changed the "subject line" as well. The PIT driver moved
recently (3.18).
Daniel,
Can you take this patch in your tree?
Thanks, bye.
Nicolas.
drivers/clocksource/timer-atmel-pit.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index b5b4d4585c9a..5408bc7c68d8 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -123,6 +123,10 @@ static void at91sam926x_pit_suspend(struct clock_event_device *cedev)
{
struct pit_data *data = clkevt_to_pit_data(cedev);
+ /* Don't suspend PIT if unused */
+ if (cedev->mode == CLOCK_EVT_MODE_UNUSED)
+ return;
+
/* Disable timer */
pit_write(data->base, AT91_PIT_MR, 0);
}
@@ -145,6 +149,10 @@ static void at91sam926x_pit_resume(struct clock_event_device *cedev)
{
struct pit_data *data = clkevt_to_pit_data(cedev);
+ /* Don't resume PIT if unused */
+ if (cedev->mode == CLOCK_EVT_MODE_UNUSED)
+ return;
+
at91sam926x_pit_reset(data);
}
--
2.1.3
next reply other threads:[~2014-12-18 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 14:05 Nicolas Ferre [this message]
2015-01-12 14:04 ` [PATCH] clocksource: timer-atmel-pit: don't suspend/resume if unused Nicolas Ferre
2015-01-12 14:22 ` Daniel Lezcano
2015-01-13 10:47 ` Thomas Gleixner
2015-01-15 11:41 ` Daniel Lezcano
2015-01-15 11:52 ` Alexandre Belloni
2015-01-15 12:23 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418911523-28492-1-git-send-email-nicolas.ferre@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).