* [PATCH repost 03/16] arm64/uaccess: fix sparse errors
[not found] <1419499661-8566-1-git-send-email-mst@redhat.com>
@ 2014-12-25 9:28 ` Michael S. Tsirkin
2015-01-23 15:33 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2014-12-25 9:28 UTC (permalink / raw)
To: linux-arm-kernel
virtio wants to read bitwise types from userspace using get_user. At the
moment this triggers sparse errors, since the value is passed through an
integer.
Fix that up using __force.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Will Deacon <will.deacon@arm.com>
---
arch/arm64/include/asm/uaccess.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index 3bf8f4e..8d66bcf 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -147,7 +147,7 @@ do { \
default: \
BUILD_BUG(); \
} \
- (x) = (__typeof__(*(ptr)))__gu_val; \
+ (x) = (__force __typeof__(*(ptr)))__gu_val; \
} while (0)
#define __get_user(x, ptr) \
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH repost 03/16] arm64/uaccess: fix sparse errors
2014-12-25 9:28 ` [PATCH repost 03/16] arm64/uaccess: fix sparse errors Michael S. Tsirkin
@ 2015-01-23 15:33 ` Catalin Marinas
2015-01-23 15:42 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: Catalin Marinas @ 2015-01-23 15:33 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 25, 2014 at 09:28:41AM +0000, Michael S. Tsirkin wrote:
> virtio wants to read bitwise types from userspace using get_user. At the
> moment this triggers sparse errors, since the value is passed through an
> integer.
>
> Fix that up using __force.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Acked-by: Will Deacon <will.deacon@arm.com>
I'm not sure who's going to merge this series. In the meantime, I
cherry-picked the arm64 patch. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH repost 03/16] arm64/uaccess: fix sparse errors
2015-01-23 15:33 ` Catalin Marinas
@ 2015-01-23 15:42 ` Will Deacon
2015-01-23 16:35 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: Will Deacon @ 2015-01-23 15:42 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 23, 2015 at 03:33:16PM +0000, Catalin Marinas wrote:
> On Thu, Dec 25, 2014 at 09:28:41AM +0000, Michael S. Tsirkin wrote:
> > virtio wants to read bitwise types from userspace using get_user. At the
> > moment this triggers sparse errors, since the value is passed through an
> > integer.
> >
> > Fix that up using __force.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Acked-by: Will Deacon <will.deacon@arm.com>
>
> I'm not sure who's going to merge this series. In the meantime, I
> cherry-picked the arm64 patch. Thanks.
I think there was a pull request for the whole series that went to Arnd, so
I don't think we need to do anything on the arm64 side.
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH repost 03/16] arm64/uaccess: fix sparse errors
2015-01-23 15:42 ` Will Deacon
@ 2015-01-23 16:35 ` Catalin Marinas
0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2015-01-23 16:35 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 23, 2015 at 03:42:14PM +0000, Will Deacon wrote:
> On Fri, Jan 23, 2015 at 03:33:16PM +0000, Catalin Marinas wrote:
> > On Thu, Dec 25, 2014 at 09:28:41AM +0000, Michael S. Tsirkin wrote:
> > > virtio wants to read bitwise types from userspace using get_user. At the
> > > moment this triggers sparse errors, since the value is passed through an
> > > integer.
> > >
> > > Fix that up using __force.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > Acked-by: Will Deacon <will.deacon@arm.com>
> >
> > I'm not sure who's going to merge this series. In the meantime, I
> > cherry-picked the arm64 patch. Thanks.
>
> I think there was a pull request for the whole series that went to Arnd, so
> I don't think we need to do anything on the arm64 side.
OK. I dropped the patch.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-23 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1419499661-8566-1-git-send-email-mst@redhat.com>
2014-12-25 9:28 ` [PATCH repost 03/16] arm64/uaccess: fix sparse errors Michael S. Tsirkin
2015-01-23 15:33 ` Catalin Marinas
2015-01-23 15:42 ` Will Deacon
2015-01-23 16:35 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).