From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>,
Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
clang-built-linux@googlegroups.com, soc@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: ep93xx: don't use clang IAS for crunch
Date: Fri, 26 Feb 2021 20:23:24 +0100 [thread overview]
Message-ID: <141f3098744ea8d1cc39abcdce89c0e513bfbc70.camel@gmail.com> (raw)
In-Reply-To: <20210226164345.3889993-1-arnd@kernel.org>
Hi!
On Fri, 2021-02-26 at 17:43 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Randconfig builds with ep93xx fail with the clang integrated
> assembler that does not understand the maverick crunch extensions:
>
> arch/arm/mach-ep93xx/crunch-bits.S:94:2: error: invalid instruction
> cfstr64 mvdx0, [r1, #0] @ save 64b registers
>
> It is unclear if anyone is still using support for crunch: gcc-4.8 dropped
> it in 2012 when it was already too broken to be used reliabled. glibc
> support existed as an external patch but was never merged upstream.
> We could consider removing the last bits of the kernel support as well.
This was my impression already in 2006, that Cirrus is not going to work
on Crunch support. From my PoV it's OK to remove the support in the
kernel completely.
> Turn off the integrated assembler for this file for now.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-ep93xx/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
> index 86768495f61d..f686577ba059 100644
> --- a/arch/arm/mach-ep93xx/Makefile
> +++ b/arch/arm/mach-ep93xx/Makefile
> @@ -7,7 +7,7 @@ obj-y := core.o clock.o timer-ep93xx.o
> obj-$(CONFIG_EP93XX_DMA) += dma.o
>
> obj-$(CONFIG_CRUNCH) += crunch.o crunch-bits.o
> -AFLAGS_crunch-bits.o := -Wa,-mcpu=ep9312
> +AFLAGS_crunch-bits.o := -Wa,-mcpu=ep9312 $(cc-option, -fno-integrated-as)
>
> obj-$(CONFIG_MACH_ADSSPHERE) += adssphere.o
> obj-$(CONFIG_MACH_EDB93XX) += edb93xx.o
--
Alexander Sverdlin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-26 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:43 [PATCH] ARM: ep93xx: don't use clang IAS for crunch Arnd Bergmann
2021-02-26 18:00 ` Arnd Bergmann
2021-06-03 23:27 ` Nick Desaulniers
2021-02-26 19:23 ` Alexander Sverdlin [this message]
2021-02-26 19:32 ` Hartley Sweeten
2021-02-26 20:47 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141f3098744ea8d1cc39abcdce89c0e513bfbc70.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox