* [PATCH] video: vt8500lcdfb: remove unneeded continue
@ 2015-01-06 12:45 Sudip Mukherjee
2015-01-06 18:31 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-01-06 12:45 UTC (permalink / raw)
To: linux-arm-kernel
continue is not needed at the end of a for loop
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/video/fbdev/vt8500lcdfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
index ffaf29e..6716bf5 100644
--- a/drivers/video/fbdev/vt8500lcdfb.c
+++ b/drivers/video/fbdev/vt8500lcdfb.c
@@ -115,7 +115,6 @@ static int vt8500lcd_set_par(struct fb_info *info)
for (i = 0; i < 8; i++) {
if (bpp_values[i] == info->var.bits_per_pixel) {
reg_bpp = i;
- continue;
}
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] video: vt8500lcdfb: remove unneeded continue
2015-01-06 12:45 [PATCH] video: vt8500lcdfb: remove unneeded continue Sudip Mukherjee
@ 2015-01-06 18:31 ` Sergei Shtylyov
2015-01-07 4:46 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2015-01-06 18:31 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 01/06/2015 03:45 PM, Sudip Mukherjee wrote:
> continue is not needed at the end of a for loop
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/video/fbdev/vt8500lcdfb.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> index ffaf29e..6716bf5 100644
> --- a/drivers/video/fbdev/vt8500lcdfb.c
> +++ b/drivers/video/fbdev/vt8500lcdfb.c
> @@ -115,7 +115,6 @@ static int vt8500lcd_set_par(struct fb_info *info)
> for (i = 0; i < 8; i++) {
> if (bpp_values[i] == info->var.bits_per_pixel) {
> reg_bpp = i;
> - continue;
> }
{} are not needed any more either. ;-)
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] video: vt8500lcdfb: remove unneeded continue
2015-01-06 18:31 ` Sergei Shtylyov
@ 2015-01-07 4:46 ` Sudip Mukherjee
0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-01-07 4:46 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 06, 2015 at 09:31:39PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 01/06/2015 03:45 PM, Sudip Mukherjee wrote:
>
> >continue is not needed at the end of a for loop
>
> >Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >---
> > drivers/video/fbdev/vt8500lcdfb.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> >diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> >index ffaf29e..6716bf5 100644
> >--- a/drivers/video/fbdev/vt8500lcdfb.c
> >+++ b/drivers/video/fbdev/vt8500lcdfb.c
> >@@ -115,7 +115,6 @@ static int vt8500lcd_set_par(struct fb_info *info)
> > for (i = 0; i < 8; i++) {
> > if (bpp_values[i] == info->var.bits_per_pixel) {
> > reg_bpp = i;
> >- continue;
> > }
>
> {} are not needed any more either. ;-)
i have noticed that but thought that will be again a different type of change in a single patch.
but now it seems that this patch will introduce a new checkpatch warning, so i should have corrected that in it.
i will send a v2.
thanks
sudip
>
> [...]
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-07 4:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 12:45 [PATCH] video: vt8500lcdfb: remove unneeded continue Sudip Mukherjee
2015-01-06 18:31 ` Sergei Shtylyov
2015-01-07 4:46 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).