From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx51-babbage: Fix ULPI PHY reset modelling
Date: Tue, 06 Jan 2015 14:54:19 +0100 [thread overview]
Message-ID: <1420552459.2333.18.camel@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5Bn58O2Mr4SsBqWbiwecOKOiQMDDugLzi+aRVf+jOx=Sg@mail.gmail.com>
Am Dienstag, den 06.01.2015, 11:47 -0200 schrieb Fabio Estevam:
> On Tue, Jan 6, 2015 at 11:36 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
>
> > For the record:
> > I'm not happy with this patch. It still abuses the regulator API for
> > something completely unrelated and this may well break again in the
> > future. But given that it fixes an actual regression and you already
> > sent a pull including this I'm okay to keep it.
> >
> > We still need a proper fix to handle ULPI resets to get rid of this
> > hackery.
>
> Actually the ULPI PHY reset is properly handled now. What is missing
> is the USB Hub reset to be properly handled.
>
No it is not. A regulator isn't the proper abstraction for a reset at
all. Even if you (ab)use the regulator drivers ability to toggle a reset
GPIO.
A ULPI PHY reset needs to be modeled as a GPIO reset attached to USB
controller node. There is no other way to describe the hardware
accurately.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-01-06 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 17:19 [PATCH] ARM: dts: imx51-babbage: Fix ULPI PHY reset modelling Fabio Estevam
2015-01-06 12:43 ` Shawn Guo
2015-01-06 13:36 ` Lucas Stach
2015-01-06 13:41 ` Shawn Guo
2015-01-06 13:47 ` Fabio Estevam
2015-01-06 13:54 ` Lucas Stach [this message]
2015-01-06 13:59 ` Fabio Estevam
2015-01-06 14:03 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420552459.2333.18.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).