* [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
@ 2015-01-06 17:42 Anand Moon
2015-01-07 9:04 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Anand Moon @ 2015-01-06 17:42 UTC (permalink / raw)
To: linux-arm-kernel
ARM Enable CONFIG_LOCKUP_DETECTOR to validaion of kernel locks
Tested on Exynos5422 ODROID XU3 board.
Signed-off-by: Anand Moon <moon.linux@yahoo.com>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 5ef14de..ecd9987 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
CONFIG_DEBUG_FS=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_KERNEL=y
+CONFIG_LOCKUP_DETECTOR=y
CONFIG_DETECT_HUNG_TASK=y
CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-06 17:42 [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR Anand Moon
@ 2015-01-07 9:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-07 9:04 UTC (permalink / raw)
To: linux-arm-kernel
On wto, 2015-01-06 at 23:12 +0530, Anand Moon wrote:
> ARM Enable CONFIG_LOCKUP_DETECTOR to validaion of kernel locks
s/validaion/validation/
This config item helps getting some useful information when lockup
happens. If you want to validate locks then probably you want
PROVE_LOCKING... but its overhead is larger.
Anyway the overhead of LOCKUP_DETECTOR is small and multi_v7_defconfig
has it enabled so I guess exynos may do it as well.
Could you only fix up the commit msg?
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
>
> Tested on Exynos5422 ODROID XU3 board.
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> CONFIG_DEBUG_FS=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
> CONFIG_DETECT_HUNG_TASK=y
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
@ 2015-01-07 12:15 Anand Moon
2015-01-07 12:22 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Anand Moon @ 2015-01-07 12:15 UTC (permalink / raw)
To: linux-arm-kernel
ARM Enable CONFIG_LOCKUP_DETECTOR to validation of kernel locks
v2 Fixed the commit log
This config item helps getting some useful information when lockup
happens. If you want to validate locks then probably you want
PROVE_LOCKING... but its overhead is larger.
Anyway the overhead of LOCKUP_DETECTOR is small and multi_v7_defconfig
has it enabled so I guess exynos may do it as well.
Tested on Exynos5422 ODROID XU3 board.
Signed-off-by: Anand Moon <moon.linux@yahoo.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 5ef14de..ecd9987 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
CONFIG_DEBUG_FS=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_KERNEL=y
+CONFIG_LOCKUP_DETECTOR=y
CONFIG_DETECT_HUNG_TASK=y
CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-07 12:15 Anand Moon
@ 2015-01-07 12:22 ` Krzysztof Kozlowski
2015-01-07 12:30 ` Anand Moon
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-07 12:22 UTC (permalink / raw)
To: linux-arm-kernel
On ?ro, 2015-01-07 at 17:45 +0530, Anand Moon wrote:
> ARM Enable CONFIG_LOCKUP_DETECTOR to validation of kernel locks
>
> v2 Fixed the commit log
> This config item helps getting some useful information when lockup
> happens. If you want to validate locks then probably you want
> PROVE_LOCKING... but its overhead is larger.
>
> Anyway the overhead of LOCKUP_DETECTOR is small and multi_v7_defconfig
> has it enabled so I guess exynos may do it as well.
Err? Why did you include my response as commit message? It does not
really make sense.
Let me point this once again:
1. The commit message is inaccurate because CONFIG_LOCKUP_DETECTOR does
not validate the locks.
2. Please write proper commit message describing WHY you want to add
this config option.
Best regards,
Krzysztof
>
> Tested on Exynos5422 ODROID XU3 board.
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> CONFIG_DEBUG_FS=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
> CONFIG_DETECT_HUNG_TASK=y
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-07 12:22 ` Krzysztof Kozlowski
@ 2015-01-07 12:30 ` Anand Moon
0 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2015-01-07 12:30 UTC (permalink / raw)
To: linux-arm-kernel
Hi Krzysztof Kozlowski,
Thanks for review
I will send patch v2 with proper reason.
-Anand Moon
On Wednesday, January 7, 2015 5:52 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
On ?ro, 2015-01-07 at 17:45 +0530, Anand Moon wrote:
> ARM Enable CONFIG_LOCKUP_DETECTOR to validation of kernel locks
>
> v2 Fixed the commit log
> This config item helps getting some useful information when lockup
> happens. If you want to validate locks then probably you want
> PROVE_LOCKING... but its overhead is larger.
>
> Anyway the overhead of LOCKUP_DETECTOR is small and multi_v7_defconfig
> has it enabled so I guess exynos may do it as well.
Err? Why did you include my response as commit message? It does not
really make sense.
Let me point this once again:
1. The commit message is inaccurate because CONFIG_LOCKUP_DETECTOR does
not validate the locks.
2. Please write proper commit message describing WHY you want to add
this config option.
Best regards,
Krzysztof
>
> Tested on Exynos5422 ODROID XU3 board.
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> CONFIG_DEBUG_FS=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
> CONFIG_DETECT_HUNG_TASK=y
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-07 12:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 17:42 [PATCH] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR Anand Moon
2015-01-07 9:04 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2015-01-07 12:15 Anand Moon
2015-01-07 12:22 ` Krzysztof Kozlowski
2015-01-07 12:30 ` Anand Moon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).