* [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
@ 2015-01-07 12:59 Anand Moon
2015-01-07 13:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Anand Moon @ 2015-01-07 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
and it tracks dependencies between different lock-classes.
The validator maintains a rolling proof that the state and
the dependencies are correct.
Changes since v2:
* Made commit message more clear
* Corrected grammer in code comment
Tested on Exynos5422 ODROID XU3 board.
Signed-off-by: Anand Moon <moon.linux@yahoo.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 5ef14de..ecd9987 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
CONFIG_DEBUG_FS=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_KERNEL=y
+CONFIG_LOCKUP_DETECTOR=y
CONFIG_DETECT_HUNG_TASK=y
CONFIG_DEBUG_RT_MUTEXES=y
CONFIG_DEBUG_SPINLOCK=y
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-07 12:59 [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR Anand Moon
@ 2015-01-07 13:27 ` Krzysztof Kozlowski
2015-01-07 13:56 ` Anand Moon
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-07 13:27 UTC (permalink / raw)
To: linux-arm-kernel
On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
>
> Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> and it tracks dependencies between different lock-classes.
> The validator maintains a rolling proof that the state and
> the dependencies are correct.
Unfortunately this is not correct. Lockup detector does something else.
Please read the help/manual for LOCKUP_DETECTOR. You can find in
lib/Kconfig.debug (around line 667).
Best regards,
Krzysztof
>
> Changes since v2:
> * Made commit message more clear
> * Corrected grammer in code comment
>
> Tested on Exynos5422 ODROID XU3 board.
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> CONFIG_DEBUG_FS=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
> CONFIG_DETECT_HUNG_TASK=y
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-07 13:27 ` Krzysztof Kozlowski
@ 2015-01-07 13:56 ` Anand Moon
2015-01-07 14:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Anand Moon @ 2015-01-07 13:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kszysztof Kozlowski,
I picked up the bellow line from
Documentation/locking/lockdep-design.txt line no 18
I understand that by enabling this flag we could detect possible
deadlock situation with the kernel. Sorry for the noise.
-Anand Moon
On Wednesday, January 7, 2015 6:57 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
>
> Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> and it tracks dependencies between different lock-classes.
> The validator maintains a rolling proof that the state and
> the dependencies are correct.
Unfortunately this is not correct. Lockup detector does something else.
Please read the help/manual for LOCKUP_DETECTOR. You can find in
lib/Kconfig.debug (around line 667).
Best regards,
Krzysztof
>
> Changes since v2:
> * Made commit message more clear
> * Corrected grammer in code comment
>
> Tested on Exynos5422 ODROID XU3 board.
>
> Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 5ef14de..ecd9987 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> CONFIG_DEBUG_FS=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_DEBUG_KERNEL=y
> +CONFIG_LOCKUP_DETECTOR=y
> CONFIG_DETECT_HUNG_TASK=y
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-07 13:56 ` Anand Moon
@ 2015-01-07 14:23 ` Krzysztof Kozlowski
2015-01-07 14:39 ` Anand Moon
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-07 14:23 UTC (permalink / raw)
To: linux-arm-kernel
On ?ro, 2015-01-07 at 13:56 +0000, Anand Moon wrote:
> Hi Kszysztof Kozlowski,
>
> I picked up the bellow line from
>
>
> Documentation/locking/lockdep-design.txt line no 18
>
> I understand that by enabling this flag we could detect possible
>
> deadlock situation with the kernel. Sorry for the noise.
...and lockdep-design.txt describes LOCKDEP. Not LOCKUP. So why you are
enabling lockup?
Best regards,
Krzysztof
>
>
> -Anand Moon
>
>
>
> On Wednesday, January 7, 2015 6:57 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> > Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
> >
> > Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> > and it tracks dependencies between different lock-classes.
> > The validator maintains a rolling proof that the state and
> > the dependencies are correct.
>
> Unfortunately this is not correct. Lockup detector does something else.
> Please read the help/manual for LOCKUP_DETECTOR. You can find in
> lib/Kconfig.debug (around line 667).
>
> Best regards,
> Krzysztof
>
> >
> > Changes since v2:
> > * Made commit message more clear
> > * Corrected grammer in code comment
> >
> > Tested on Exynos5422 ODROID XU3 board.
> >
> > Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > arch/arm/configs/exynos_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> > index 5ef14de..ecd9987 100644
> > --- a/arch/arm/configs/exynos_defconfig
> > +++ b/arch/arm/configs/exynos_defconfig
> > @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> > CONFIG_DEBUG_FS=y
> > CONFIG_MAGIC_SYSRQ=y
> > CONFIG_DEBUG_KERNEL=y
> > +CONFIG_LOCKUP_DETECTOR=y
> > CONFIG_DETECT_HUNG_TASK=y
> > CONFIG_DEBUG_RT_MUTEXES=y
> > CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR
2015-01-07 14:23 ` Krzysztof Kozlowski
@ 2015-01-07 14:39 ` Anand Moon
0 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2015-01-07 14:39 UTC (permalink / raw)
To: linux-arm-kernel
hi Kszysztof KozlowskiHi,
Sorry for the noise. Drop it.
-Anand Moon
On Wednesday, January 7, 2015 7:53 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
On ?ro, 2015-01-07 at 13:56 +0000, Anand Moon wrote:
> Hi Kszysztof Kozlowski,
>
> I picked up the bellow line from
>
>
> Documentation/locking/lockdep-design.txt line no 18
>
> I understand that by enabling this flag we could detect possible
>
> deadlock situation with the kernel. Sorry for the noise.
...and lockdep-design.txt describes LOCKDEP. Not LOCKUP. So why you are
enabling lockup?
Best regards,
Krzysztof
>
>
> -Anand Moon
>
>
>
> On Wednesday, January 7, 2015 6:57 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On ?ro, 2015-01-07 at 18:29 +0530, Anand Moon wrote:
> > Enable CONFIG_LOCKUP_DETECTOR to validate kernel locks state for exynos SOC.
> >
> > Enabling CONFIG_LOCKUP_DETECTOR help validator tracks the 'state' of lock-classes,
> > and it tracks dependencies between different lock-classes.
> > The validator maintains a rolling proof that the state and
> > the dependencies are correct.
>
> Unfortunately this is not correct. Lockup detector does something else.
> Please read the help/manual for LOCKUP_DETECTOR. You can find in
> lib/Kconfig.debug (around line 667).
>
> Best regards,
> Krzysztof
>
> >
> > Changes since v2:
> > * Made commit message more clear
> > * Corrected grammer in code comment
> >
> > Tested on Exynos5422 ODROID XU3 board.
> >
> > Signed-off-by: Anand Moon <moon.linux@yahoo.com>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > arch/arm/configs/exynos_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> > index 5ef14de..ecd9987 100644
> > --- a/arch/arm/configs/exynos_defconfig
> > +++ b/arch/arm/configs/exynos_defconfig
> > @@ -178,6 +178,7 @@ CONFIG_PRINTK_TIME=y
> > CONFIG_DEBUG_FS=y
> > CONFIG_MAGIC_SYSRQ=y
> > CONFIG_DEBUG_KERNEL=y
> > +CONFIG_LOCKUP_DETECTOR=y
> > CONFIG_DETECT_HUNG_TASK=y
> > CONFIG_DEBUG_RT_MUTEXES=y
> > CONFIG_DEBUG_SPINLOCK=y
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-07 14:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-07 12:59 [PATCH v2] ARM: exynos_defconfig: Enable CONFIG_LOCKUP_DETECTOR Anand Moon
2015-01-07 13:27 ` Krzysztof Kozlowski
2015-01-07 13:56 ` Anand Moon
2015-01-07 14:23 ` Krzysztof Kozlowski
2015-01-07 14:39 ` Anand Moon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox