linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tyler.baker@linaro.org (Tyler Baker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] reset: sunxi: fix spinlock initialization
Date: Wed,  7 Jan 2015 16:54:39 -0800	[thread overview]
Message-ID: <1420678479-630-1-git-send-email-tyler.baker@linaro.org> (raw)

Call spin_lock_init() before the spinlocks are used, preventing a lockdep
splat.

I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
and has been tested on a few other sunxi platforms without issue.

[1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
[2] http://kernelci.org/boot/?a80-optimus

Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
This patch was tested on 3.19.0-rc3 

 drivers/reset/reset-sunxi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index eebc52c..e37250c 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -157,6 +157,8 @@ static int sunxi_reset_probe(struct platform_device *pdev)
 	if (IS_ERR(data->membase))
 		return PTR_ERR(data->membase);
 
+	spin_lock_init(&data->lock);
+
 	data->rcdev.owner = THIS_MODULE;
 	data->rcdev.nr_resets = resource_size(res) * 32;
 	data->rcdev.ops = &sunxi_reset_ops;
-- 
2.1.3

             reply	other threads:[~2015-01-08  0:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08  0:54 Tyler Baker [this message]
2015-01-08  9:09 ` [PATCH] reset: sunxi: fix spinlock initialization Philipp Zabel
2015-01-08  9:30 ` Maxime Ripard
2015-01-09  6:38   ` Tyler Baker
2015-01-09 11:59 ` Maxime Coquelin
2015-01-09 14:44   ` Maxime Coquelin
2015-01-09 20:44     ` Tyler Baker
2015-01-10  0:22       ` Tyler Baker
2015-01-12  8:37         ` Philipp Zabel
2015-01-13  8:59         ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420678479-630-1-git-send-email-tyler.baker@linaro.org \
    --to=tyler.baker@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).