* [PATCH 1/3] soc/tegra: Add Tegra132 support @ 2015-01-08 7:24 Thierry Reding 2015-01-08 7:24 ` [PATCH 2/3] soc/tegra: fuse: Constify tegra_fuse_info structures Thierry Reding 2015-01-08 7:24 ` [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support Thierry Reding 0 siblings, 2 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-08 7:24 UTC (permalink / raw) To: linux-arm-kernel From: Thierry Reding <treding@nvidia.com> Add the chip ID for the NVIDIA Tegra132 SoC family. Signed-off-by: Thierry Reding <treding@nvidia.com> --- include/soc/tegra/fuse.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/soc/tegra/fuse.h b/include/soc/tegra/fuse.h index 8e1249474e84..b5f7b5f8d008 100644 --- a/include/soc/tegra/fuse.h +++ b/include/soc/tegra/fuse.h @@ -21,6 +21,7 @@ #define TEGRA30 0x30 #define TEGRA114 0x35 #define TEGRA124 0x40 +#define TEGRA132 0x13 #define TEGRA_FUSE_SKU_CALIB_0 0xf0 #define TEGRA30_FUSE_SATA_CALIB 0x124 -- 2.1.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] soc/tegra: fuse: Constify tegra_fuse_info structures 2015-01-08 7:24 [PATCH 1/3] soc/tegra: Add Tegra132 support Thierry Reding @ 2015-01-08 7:24 ` Thierry Reding 2015-01-08 7:24 ` [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support Thierry Reding 1 sibling, 0 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-08 7:24 UTC (permalink / raw) To: linux-arm-kernel From: Thierry Reding <treding@nvidia.com> These structures contain read-only data and are never modified, so they can be const. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/soc/tegra/fuse/fuse-tegra30.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c index 8646fa920d8d..d1a4290cda5c 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra30.c +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c @@ -56,7 +56,7 @@ struct tegra_fuse_info { static void __iomem *fuse_base; static struct clk *fuse_clk; -static struct tegra_fuse_info *fuse_info; +static const struct tegra_fuse_info *fuse_info; u32 tegra30_fuse_readl(const unsigned int offset) { @@ -78,18 +78,18 @@ u32 tegra30_fuse_readl(const unsigned int offset) return val; } -static struct tegra_fuse_info tegra30_info = { +static const struct tegra_fuse_info tegra30_info = { .size = 0x2a4, .spare_bit = 0x144, .speedo_idx = SPEEDO_TEGRA30, }; -static struct tegra_fuse_info tegra114_info = { +static const struct tegra_fuse_info tegra114_info = { .size = 0x2a0, .speedo_idx = SPEEDO_TEGRA114, }; -static struct tegra_fuse_info tegra124_info = { +static const struct tegra_fuse_info tegra124_info = { .size = 0x300, .speedo_idx = SPEEDO_TEGRA124, }; -- 2.1.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-08 7:24 [PATCH 1/3] soc/tegra: Add Tegra132 support Thierry Reding 2015-01-08 7:24 ` [PATCH 2/3] soc/tegra: fuse: Constify tegra_fuse_info structures Thierry Reding @ 2015-01-08 7:24 ` Thierry Reding 2015-01-08 7:42 ` Vince Hsu 2015-01-08 8:55 ` [PATCH v2 " Thierry Reding 1 sibling, 2 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-08 7:24 UTC (permalink / raw) To: linux-arm-kernel From: Thierry Reding <treding@nvidia.com> Tegra132 is very similar to Tegra124 from a peripheral point of view and uses the same fuse controller. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/soc/tegra/fuse/fuse-tegra.c | 1 + drivers/soc/tegra/fuse/fuse-tegra30.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c index 011a3363c265..c0d660f1aaac 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { { .compatible = "nvidia,tegra30-car", }, { .compatible = "nvidia,tegra114-car", }, { .compatible = "nvidia,tegra124-car", }, + { .compatible = "nvidia,tegra132-car", }, {}, }; diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c index d1a4290cda5c..11fe22e0de73 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra30.c +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c @@ -184,6 +184,8 @@ static void __init legacy_fuse_init(void) case TEGRA124: fuse_info = &tegra124_info; break; + case TEGRA132: + fuse_info = &tegra124_info; default: return; } -- 2.1.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-08 7:24 ` [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support Thierry Reding @ 2015-01-08 7:42 ` Vince Hsu 2015-01-08 8:50 ` Thierry Reding 2015-01-08 8:55 ` [PATCH v2 " Thierry Reding 1 sibling, 1 reply; 9+ messages in thread From: Vince Hsu @ 2015-01-08 7:42 UTC (permalink / raw) To: linux-arm-kernel On 01/08/2015 03:24 PM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Tegra132 is very similar to Tegra124 from a peripheral point of view and > uses the same fuse controller. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/soc/tegra/fuse/fuse-tegra.c | 1 + > drivers/soc/tegra/fuse/fuse-tegra30.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c > index 011a3363c265..c0d660f1aaac 100644 > --- a/drivers/soc/tegra/fuse/fuse-tegra.c > +++ b/drivers/soc/tegra/fuse/fuse-tegra.c > @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { > { .compatible = "nvidia,tegra30-car", }, > { .compatible = "nvidia,tegra114-car", }, > { .compatible = "nvidia,tegra124-car", }, > + { .compatible = "nvidia,tegra132-car", }, > {}, > }; > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c > index d1a4290cda5c..11fe22e0de73 100644 > --- a/drivers/soc/tegra/fuse/fuse-tegra30.c > +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c > @@ -184,6 +184,8 @@ static void __init legacy_fuse_init(void) > case TEGRA124: > fuse_info = &tegra124_info; > break; > + case TEGRA132: > + fuse_info = &tegra124_info; Fall through intentionally? > default: > return; > } ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-08 7:42 ` Vince Hsu @ 2015-01-08 8:50 ` Thierry Reding 0 siblings, 0 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-08 8:50 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 08, 2015 at 03:42:14PM +0800, Vince Hsu wrote: > > On 01/08/2015 03:24 PM, Thierry Reding wrote: > >From: Thierry Reding <treding@nvidia.com> > > > >Tegra132 is very similar to Tegra124 from a peripheral point of view and > >uses the same fuse controller. > > > >Signed-off-by: Thierry Reding <treding@nvidia.com> > >--- > > drivers/soc/tegra/fuse/fuse-tegra.c | 1 + > > drivers/soc/tegra/fuse/fuse-tegra30.c | 2 ++ > > 2 files changed, 3 insertions(+) > > > >diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c > >index 011a3363c265..c0d660f1aaac 100644 > >--- a/drivers/soc/tegra/fuse/fuse-tegra.c > >+++ b/drivers/soc/tegra/fuse/fuse-tegra.c > >@@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { > > { .compatible = "nvidia,tegra30-car", }, > > { .compatible = "nvidia,tegra114-car", }, > > { .compatible = "nvidia,tegra124-car", }, > >+ { .compatible = "nvidia,tegra132-car", }, > > {}, > > }; > >diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c > >index d1a4290cda5c..11fe22e0de73 100644 > >--- a/drivers/soc/tegra/fuse/fuse-tegra30.c > >+++ b/drivers/soc/tegra/fuse/fuse-tegra30.c > >@@ -184,6 +184,8 @@ static void __init legacy_fuse_init(void) > > case TEGRA124: > > fuse_info = &tegra124_info; > > break; > >+ case TEGRA132: > >+ fuse_info = &tegra124_info; > Fall through intentionally? Nope, good catch. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150108/fb1c0a7e/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-08 7:24 ` [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support Thierry Reding 2015-01-08 7:42 ` Vince Hsu @ 2015-01-08 8:55 ` Thierry Reding 2015-01-09 3:49 ` Alexandre Courbot 2015-01-09 10:49 ` [PATCH v3 " Thierry Reding 1 sibling, 2 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-08 8:55 UTC (permalink / raw) To: linux-arm-kernel From: Thierry Reding <treding@nvidia.com> Tegra132 is very similar to Tegra124 from a peripheral point of view and uses the same fuse controller. Signed-off-by: Thierry Reding <treding@nvidia.com> --- Changes in v2: - add missing break in Tegra132 case for legacy fuse init (Vince Hsu) drivers/soc/tegra/fuse/fuse-tegra.c | 1 + drivers/soc/tegra/fuse/fuse-tegra30.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c index 011a3363c265..c0d660f1aaac 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { { .compatible = "nvidia,tegra30-car", }, { .compatible = "nvidia,tegra114-car", }, { .compatible = "nvidia,tegra124-car", }, + { .compatible = "nvidia,tegra132-car", }, {}, }; diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c index d1a4290cda5c..9e3679594259 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra30.c +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c @@ -184,6 +184,9 @@ static void __init legacy_fuse_init(void) case TEGRA124: fuse_info = &tegra124_info; break; + case TEGRA132: + fuse_info = &tegra124_info; + break; default: return; } -- 2.1.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-08 8:55 ` [PATCH v2 " Thierry Reding @ 2015-01-09 3:49 ` Alexandre Courbot 2015-01-09 10:05 ` Thierry Reding 2015-01-09 10:49 ` [PATCH v3 " Thierry Reding 1 sibling, 1 reply; 9+ messages in thread From: Alexandre Courbot @ 2015-01-09 3:49 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jan 8, 2015 at 5:55 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > From: Thierry Reding <treding@nvidia.com> > > Tegra132 is very similar to Tegra124 from a peripheral point of view and > uses the same fuse controller. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > Changes in v2: > - add missing break in Tegra132 case for legacy fuse init (Vince Hsu) > > drivers/soc/tegra/fuse/fuse-tegra.c | 1 + > drivers/soc/tegra/fuse/fuse-tegra30.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c > index 011a3363c265..c0d660f1aaac 100644 > --- a/drivers/soc/tegra/fuse/fuse-tegra.c > +++ b/drivers/soc/tegra/fuse/fuse-tegra.c > @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { > { .compatible = "nvidia,tegra30-car", }, > { .compatible = "nvidia,tegra114-car", }, > { .compatible = "nvidia,tegra124-car", }, > + { .compatible = "nvidia,tegra132-car", }, > {}, > }; > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c > index d1a4290cda5c..9e3679594259 100644 > --- a/drivers/soc/tegra/fuse/fuse-tegra30.c > +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c > @@ -184,6 +184,9 @@ static void __init legacy_fuse_init(void) > case TEGRA124: > fuse_info = &tegra124_info; > break; > + case TEGRA132: > + fuse_info = &tegra124_info; > + break; Nit, but why not case TEGRA124: + case TEGRA132: fuse_info = &tegra124_info; break; ? ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-09 3:49 ` Alexandre Courbot @ 2015-01-09 10:05 ` Thierry Reding 0 siblings, 0 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-09 10:05 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jan 09, 2015 at 12:49:25PM +0900, Alexandre Courbot wrote: > On Thu, Jan 8, 2015 at 5:55 PM, Thierry Reding <thierry.reding@gmail.com> wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > Tegra132 is very similar to Tegra124 from a peripheral point of view and > > uses the same fuse controller. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > Changes in v2: > > - add missing break in Tegra132 case for legacy fuse init (Vince Hsu) > > > > drivers/soc/tegra/fuse/fuse-tegra.c | 1 + > > drivers/soc/tegra/fuse/fuse-tegra30.c | 3 +++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c > > index 011a3363c265..c0d660f1aaac 100644 > > --- a/drivers/soc/tegra/fuse/fuse-tegra.c > > +++ b/drivers/soc/tegra/fuse/fuse-tegra.c > > @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { > > { .compatible = "nvidia,tegra30-car", }, > > { .compatible = "nvidia,tegra114-car", }, > > { .compatible = "nvidia,tegra124-car", }, > > + { .compatible = "nvidia,tegra132-car", }, > > {}, > > }; > > > > diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c > > index d1a4290cda5c..9e3679594259 100644 > > --- a/drivers/soc/tegra/fuse/fuse-tegra30.c > > +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c > > @@ -184,6 +184,9 @@ static void __init legacy_fuse_init(void) > > case TEGRA124: > > fuse_info = &tegra124_info; > > break; > > + case TEGRA132: > > + fuse_info = &tegra124_info; > > + break; > > Nit, but why not > > case TEGRA124: > + case TEGRA132: > fuse_info = &tegra124_info; > break; Yes, that's even better. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150109/a8f08b0d/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 3/3] soc/tegra: fuse: Add Tegra132 support 2015-01-08 8:55 ` [PATCH v2 " Thierry Reding 2015-01-09 3:49 ` Alexandre Courbot @ 2015-01-09 10:49 ` Thierry Reding 1 sibling, 0 replies; 9+ messages in thread From: Thierry Reding @ 2015-01-09 10:49 UTC (permalink / raw) To: linux-arm-kernel From: Thierry Reding <treding@nvidia.com> Tegra132 is very similar to Tegra124 from a peripheral point of view and uses the same fuse controller. Signed-off-by: Thierry Reding <treding@nvidia.com> --- Changes in v3: - collapse TEGRA124 and TEGRA132 cases into a single one (Alex Courbot) Changes in v2: - add missing break in Tegra132 case for legacy fuse init (Vince Hsu) --- drivers/soc/tegra/fuse/fuse-tegra.c | 1 + drivers/soc/tegra/fuse/fuse-tegra30.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c index 011a3363c265..c0d660f1aaac 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -81,6 +81,7 @@ static const struct of_device_id car_match[] __initconst = { { .compatible = "nvidia,tegra30-car", }, { .compatible = "nvidia,tegra114-car", }, { .compatible = "nvidia,tegra124-car", }, + { .compatible = "nvidia,tegra132-car", }, {}, }; diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c index d1a4290cda5c..4d2f71bf65c5 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra30.c +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c @@ -182,6 +182,7 @@ static void __init legacy_fuse_init(void) fuse_info = &tegra114_info; break; case TEGRA124: + case TEGRA132: fuse_info = &tegra124_info; break; default: -- 2.1.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-01-09 10:49 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-08 7:24 [PATCH 1/3] soc/tegra: Add Tegra132 support Thierry Reding 2015-01-08 7:24 ` [PATCH 2/3] soc/tegra: fuse: Constify tegra_fuse_info structures Thierry Reding 2015-01-08 7:24 ` [PATCH 3/3] soc/tegra: fuse: Add Tegra132 support Thierry Reding 2015-01-08 7:42 ` Vince Hsu 2015-01-08 8:50 ` Thierry Reding 2015-01-08 8:55 ` [PATCH v2 " Thierry Reding 2015-01-09 3:49 ` Alexandre Courbot 2015-01-09 10:05 ` Thierry Reding 2015-01-09 10:49 ` [PATCH v3 " Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).