* [PATCH RESEND] reset: sunxi: fix spinlock initialization
@ 2015-01-12 15:54 Tyler Baker
2015-01-12 16:17 ` Maxime Ripard
0 siblings, 1 reply; 6+ messages in thread
From: Tyler Baker @ 2015-01-12 15:54 UTC (permalink / raw)
To: linux-arm-kernel
Call spin_lock_init() before the spinlocks are used, both in early init
and probe functions preventing a lockdep splat.
I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
and has been tested on a few other sunxi platforms without issue.
[1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
[2] http://kernelci.org/boot/?a80-optimus
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
Cc: <stable@vger.kernel.org>
---
drivers/reset/reset-sunxi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index eebc52c..3d95c87 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -102,6 +102,8 @@ static int sunxi_reset_init(struct device_node *np)
goto err_alloc;
}
+ spin_lock_init(&data->lock);
+
data->rcdev.owner = THIS_MODULE;
data->rcdev.nr_resets = size * 32;
data->rcdev.ops = &sunxi_reset_ops;
@@ -157,6 +159,8 @@ static int sunxi_reset_probe(struct platform_device *pdev)
if (IS_ERR(data->membase))
return PTR_ERR(data->membase);
+ spin_lock_init(&data->lock);
+
data->rcdev.owner = THIS_MODULE;
data->rcdev.nr_resets = resource_size(res) * 32;
data->rcdev.ops = &sunxi_reset_ops;
--
2.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RESEND] reset: sunxi: fix spinlock initialization
2015-01-12 15:54 [PATCH RESEND] reset: sunxi: fix spinlock initialization Tyler Baker
@ 2015-01-12 16:17 ` Maxime Ripard
2015-01-12 22:13 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2015-01-12 16:17 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
> Call spin_lock_init() before the spinlocks are used, both in early init
> and probe functions preventing a lockdep splat.
>
> I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
> when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
> and has been tested on a few other sunxi platforms without issue.
>
> [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
> [2] http://kernelci.org/boot/?a80-optimus
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> Cc: <stable@vger.kernel.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150112/47c3ad47/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND] reset: sunxi: fix spinlock initialization
2015-01-12 16:17 ` Maxime Ripard
@ 2015-01-12 22:13 ` Olof Johansson
2015-01-13 0:41 ` Tyler Baker
2015-01-13 9:36 ` Philipp Zabel
0 siblings, 2 replies; 6+ messages in thread
From: Olof Johansson @ 2015-01-12 22:13 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 12, 2015 at 05:17:06PM +0100, Maxime Ripard wrote:
> On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
> > Call spin_lock_init() before the spinlocks are used, both in early init
> > and probe functions preventing a lockdep splat.
> >
> > I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
> > when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
> > and has been tested on a few other sunxi platforms without issue.
> >
> > [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
> > [2] http://kernelci.org/boot/?a80-optimus
> >
> > Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> > Cc: <stable@vger.kernel.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Not entirely sure what to do with this one. You sent it to:arm at kernel.org, but
it should probably have gone to Philipp?
We can pick it up with an ack from him though, no problem.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND] reset: sunxi: fix spinlock initialization
2015-01-12 22:13 ` Olof Johansson
@ 2015-01-13 0:41 ` Tyler Baker
2015-01-13 9:36 ` Philipp Zabel
1 sibling, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-01-13 0:41 UTC (permalink / raw)
To: linux-arm-kernel
On 12 January 2015 at 14:13, Olof Johansson <olof@lixom.net> wrote:
> On Mon, Jan 12, 2015 at 05:17:06PM +0100, Maxime Ripard wrote:
>> On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
>> > Call spin_lock_init() before the spinlocks are used, both in early init
>> > and probe functions preventing a lockdep splat.
>> >
>> > I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
>> > when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
>> > and has been tested on a few other sunxi platforms without issue.
>> >
>> > [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>> > [2] http://kernelci.org/boot/?a80-optimus
>> >
>> > Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> > Cc: <stable@vger.kernel.org>
>>
>> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Not entirely sure what to do with this one. You sent it to:arm at kernel.org, but
> it should probably have gone to Philipp?
Apologies, that was my copy and paste error.
>
> We can pick it up with an ack from him though, no problem.
Philipp is on CC so I'll let him decide, otherwise I can resend if needed.
>
>
> -Olof
Sorry for any confusion.
--
Tyler Baker
Tech Lead, LAVA
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND] reset: sunxi: fix spinlock initialization
2015-01-12 22:13 ` Olof Johansson
2015-01-13 0:41 ` Tyler Baker
@ 2015-01-13 9:36 ` Philipp Zabel
2015-01-15 18:37 ` Kevin Hilman
1 sibling, 1 reply; 6+ messages in thread
From: Philipp Zabel @ 2015-01-13 9:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Am Montag, den 12.01.2015, 14:13 -0800 schrieb Olof Johansson:
> On Mon, Jan 12, 2015 at 05:17:06PM +0100, Maxime Ripard wrote:
> > On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
> > > Call spin_lock_init() before the spinlocks are used, both in early init
> > > and probe functions preventing a lockdep splat.
> > >
> > > I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
> > > when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
> > > and has been tested on a few other sunxi platforms without issue.
> > >
> > > [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
> > > [2] http://kernelci.org/boot/?a80-optimus
> > >
> > > Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> > > Cc: <stable@vger.kernel.org>
> >
> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Not entirely sure what to do with this one. You sent it to:arm at kernel.org, but
> it should probably have gone to Philipp?
>
> We can pick it up with an ack from him though, no problem.
I have applied the patch here:
git://git.pengutronix.de/git/pza/linux reset/for_v3.19
I was going to send a pull request tonight, but since I don't have any
other pending fixes besides this, and you already offered to pick it up,
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH RESEND] reset: sunxi: fix spinlock initialization
2015-01-13 9:36 ` Philipp Zabel
@ 2015-01-15 18:37 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2015-01-15 18:37 UTC (permalink / raw)
To: linux-arm-kernel
Philipp Zabel <p.zabel@pengutronix.de> writes:
> Hi,
>
> Am Montag, den 12.01.2015, 14:13 -0800 schrieb Olof Johansson:
>> On Mon, Jan 12, 2015 at 05:17:06PM +0100, Maxime Ripard wrote:
>> > On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
>> > > Call spin_lock_init() before the spinlocks are used, both in early init
>> > > and probe functions preventing a lockdep splat.
>> > >
>> > > I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
>> > > when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
>> > > and has been tested on a few other sunxi platforms without issue.
>> > >
>> > > [1]
>> > > http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>> > > [2] http://kernelci.org/boot/?a80-optimus
>> > >
>> > > Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
>> > > Cc: <stable@vger.kernel.org>
>> >
>> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>
>> Not entirely sure what to do with this one. You sent it to:arm at kernel.org, but
>> it should probably have gone to Philipp?
>>
>> We can pick it up with an ack from him though, no problem.
>
> I have applied the patch here:
>
> git://git.pengutronix.de/git/pza/linux reset/for_v3.19
>
> I was going to send a pull request tonight, but since I don't have any
> other pending fixes besides this, and you already offered to pick it up,
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to arm-soc/fixes with ack from Philipp.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-15 18:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 15:54 [PATCH RESEND] reset: sunxi: fix spinlock initialization Tyler Baker
2015-01-12 16:17 ` Maxime Ripard
2015-01-12 22:13 ` Olof Johansson
2015-01-13 0:41 ` Tyler Baker
2015-01-13 9:36 ` Philipp Zabel
2015-01-15 18:37 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).