From: sjoerd.simons@collabora.co.uk (Sjoerd Simons)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors
Date: Wed, 14 Jan 2015 22:25:04 +0100 [thread overview]
Message-ID: <1421270704.2450.138.camel@collabora.co.uk> (raw)
In-Reply-To: <1421193801-24637-1-git-send-email-khilman@kernel.org>
Hey kevin,
On Tue, 2015-01-13 at 16:03 -0800, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@linaro.org>
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..7874da20939f 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c at 12C60000 {
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina220 at 40 {
^ ina231 at 40 ?
> + compatible = "ti,ina230";
This feels incredibly nitpicky, but would it not better to use ti,ina231
as it's an INA231 chip not a INA230? (And add the compatibility string
to the driver)
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150114/6ab1059a/attachment.bin>
next prev parent reply other threads:[~2015-01-14 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 0:03 [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors Kevin Hilman
2015-01-14 15:55 ` Kukjin Kim
2015-01-14 23:42 ` Kevin Hilman
2015-01-14 21:25 ` Sjoerd Simons [this message]
2015-01-14 23:44 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421270704.2450.138.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).