From mboxrd@z Thu Jan 1 00:00:00 1970 From: jamesjj.liao@mediatek.com (James Liao) Date: Tue, 20 Jan 2015 10:10:40 +0800 Subject: [PATCH v3 1/4] clk: dts: mediatek: add Mediatek MT8135 clock bindings In-Reply-To: <20150119153549.22722.67372@quantum> References: <1420601123-25859-1-git-send-email-jamesjj.liao@mediatek.com> <1420601123-25859-2-git-send-email-jamesjj.liao@mediatek.com> <20150119153549.22722.67372@quantum> Message-ID: <1421719840.11981.4.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2015-01-19 at 07:35 -0800, Mike Turquette wrote: > Quoting James Liao (2015-01-06 19:25:20) > > +Example: I2C controller node that consumes the clock generated by the clock > > + controller (refer to the standard clock bindings for information about > > + "clocks" and "clock-names" properties): > > + > > + i2c0: i2c at 1100d000 { > > + compatible = "mediatek,mt8135-i2c", "mediatek,mt6589-i2c"; > > + reg = <0 0x1100d000 0 0x70>, <0 0x11000300 0 0x80>; > > + interrupts = ; > > + clock-div = <16>; > > + clocks = <&pericfg PERI_I2C0_CK>, <&pericfg PERI_AP_DMA_CK>; > > + clock-names = "main", "dma"; > > + }; > > Hello, > > Patch looks good to me overall. One suggestion for the next version is > that your example above include a node for the clock controller itself, > followed by the i2c controller example above. OK, I'll add pericfg in next patch. Best regards, James