public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: jamesjj.liao@mediatek.com (James Liao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.
Date: Wed, 21 Jan 2015 15:49:45 +0800	[thread overview]
Message-ID: <1421826585.2437.3.camel@mtksdaap41> (raw)
In-Reply-To: <CABuKBeLFvP4ChnzzUJwoLtCHtH6PejENJueBd7D+xMJhBMDBkg@mail.gmail.com>

Hi Matthias,

On Tue, 2015-01-20 at 13:39 +0100, Matthias Brugger wrote:
> I think you should use spin_lock_irqsave(&clk_ops_lock, flags) instead
> of mtk_clk_lock.
> In any case I think you should define a spinlock in clk-mt8135.c and
> pass a reference of it in the init functions.
> See drivers/clk/berlin as a good example.

I see. I'll change it in next patch.


Best regards,
James

  reply	other threads:[~2015-01-21  7:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07  3:25 [PATCH v3 0/4] clk: mediatek: Add common clock support for Mediatek MT8135 James Liao
2015-01-07  3:25 ` [PATCH v3 1/4] clk: dts: mediatek: add Mediatek MT8135 clock bindings James Liao
2015-01-19 15:35   ` Mike Turquette
2015-01-20  2:10     ` James Liao
2015-01-07  3:25 ` [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs James Liao
2015-01-07 17:22   ` Matthias Brugger
2015-01-08  2:55     ` James Liao
2015-01-19 16:28       ` Mike Turquette
2015-01-20 12:39       ` Matthias Brugger
2015-01-21  7:49         ` James Liao [this message]
2015-01-07  3:25 ` [PATCH v3 3/4] clk: mediatek: Add basic clocks for Mediatek MT8135 James Liao
2015-01-07 17:31   ` Matthias Brugger
2015-01-08  2:59     ` James Liao
2015-01-07  3:25 ` [PATCH v3 4/4] dts: mediatek: Enable clock support " James Liao
2015-01-07 16:25   ` Matthias Brugger
2015-01-08  2:34     ` James Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421826585.2437.3.camel@mtksdaap41 \
    --to=jamesjj.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox