From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] PM / Domains: Don't check for an existing device when adding a new
Date: Tue, 27 Jan 2015 21:13:41 +0100 [thread overview]
Message-ID: <1422389625-11730-5-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1422389625-11730-1-git-send-email-ulf.hansson@linaro.org>
When adding a device to a genpd, we no longer need to walk genpd's list
of existing devices to verify it hasn't already been added.
Instead we can now rely on the verification of not allowing existing
generic_pm_domain_data for a device, since that has the same meaning.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/base/power/domain.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 76eb0c3..88198ba 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1415,7 +1415,6 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
struct gpd_timing_data *td)
{
struct generic_pm_domain_data *gpd_data_new, *gpd_data = NULL;
- struct pm_domain_data *pdd;
int ret = 0;
dev_dbg(dev, "%s()\n", __func__);
@@ -1434,12 +1433,6 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
goto out;
}
- list_for_each_entry(pdd, &genpd->dev_list, list_node)
- if (pdd->dev == dev) {
- ret = -EINVAL;
- goto out;
- }
-
ret = dev_pm_get_subsys_data(dev);
if (ret)
goto out;
--
1.9.1
next prev parent reply other threads:[~2015-01-27 20:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 20:13 [PATCH 0/8] PM / Domains: Re-structure code for adding/removing devices to genpd Ulf Hansson
2015-01-27 20:13 ` [PATCH 1/8] PM / Domains: Rename __pm_genpd_alloc|free_dev_data() Ulf Hansson
2015-01-28 10:06 ` Pavel Machek
2015-01-27 20:13 ` [PATCH 2/8] PM / Domains: Remove reference counting for the generic_pm_domain_data Ulf Hansson
2015-01-28 10:07 ` Pavel Machek
2015-01-27 20:13 ` [PATCH 3/8] PM / Domains: Don't allow an existing generic_pm_domain_data Ulf Hansson
2015-01-27 20:13 ` Ulf Hansson [this message]
2015-01-27 20:13 ` [PATCH 5/8] PM / Domains: Eliminate the mutex for the generic_pm_domain_data Ulf Hansson
2015-01-27 20:13 ` [PATCH 6/8] PM / Domains: Free pm_subsys_data in error path in __pm_genpd_add_device() Ulf Hansson
2015-01-27 20:13 ` [PATCH 7/8] PM / Domains: Re-order initialization of generic_pm_domain_data Ulf Hansson
2015-01-27 20:13 ` [PATCH 8/8] PM / Domains: Handle errors from genpd's ->attach_dev() callback Ulf Hansson
2015-01-28 9:35 ` Geert Uytterhoeven
2015-01-29 10:32 ` [PATCH 0/8] PM / Domains: Re-structure code for adding/removing devices to genpd Geert Uytterhoeven
2015-02-04 14:39 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422389625-11730-5-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).