linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] PM / Domains: Handle errors from genpd's ->attach_dev() callback
Date: Tue, 27 Jan 2015 21:13:45 +0100	[thread overview]
Message-ID: <1422389625-11730-9-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1422389625-11730-1-git-send-email-ulf.hansson@linaro.org>

The optional genpd's ->attach_dev() callback is invoked from
__pm_genpd_add_device(). Let's add error handling from the response
from this callback and propagate the error code.

When __pm_genpd_add_device() is invoked through the generic OF-based PM
domain look-up path, the device is being probed. Returning an error
will mean the device won't be attached to its PM domain. Errors of
-EPROBE_DEFER get special treatment and is propagated to the driver
core.

Therefore this change also enables the ->attach_dev() callback to
be able to request for a deferred probe sequence.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/base/power/domain.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 0fd5ee1..ba4abbe 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1467,8 +1467,9 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
 		goto out;
 	}
 
-	if (genpd->attach_dev)
-		genpd->attach_dev(genpd, dev);
+	ret = genpd->attach_dev ? genpd->attach_dev(genpd, dev) : 0;
+	if (ret)
+		goto out;
 
 	genpd->device_count++;
 	genpd->max_off_time_changed = true;
-- 
1.9.1

  parent reply	other threads:[~2015-01-27 20:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 20:13 [PATCH 0/8] PM / Domains: Re-structure code for adding/removing devices to genpd Ulf Hansson
2015-01-27 20:13 ` [PATCH 1/8] PM / Domains: Rename __pm_genpd_alloc|free_dev_data() Ulf Hansson
2015-01-28 10:06   ` Pavel Machek
2015-01-27 20:13 ` [PATCH 2/8] PM / Domains: Remove reference counting for the generic_pm_domain_data Ulf Hansson
2015-01-28 10:07   ` Pavel Machek
2015-01-27 20:13 ` [PATCH 3/8] PM / Domains: Don't allow an existing generic_pm_domain_data Ulf Hansson
2015-01-27 20:13 ` [PATCH 4/8] PM / Domains: Don't check for an existing device when adding a new Ulf Hansson
2015-01-27 20:13 ` [PATCH 5/8] PM / Domains: Eliminate the mutex for the generic_pm_domain_data Ulf Hansson
2015-01-27 20:13 ` [PATCH 6/8] PM / Domains: Free pm_subsys_data in error path in __pm_genpd_add_device() Ulf Hansson
2015-01-27 20:13 ` [PATCH 7/8] PM / Domains: Re-order initialization of generic_pm_domain_data Ulf Hansson
2015-01-27 20:13 ` Ulf Hansson [this message]
2015-01-28  9:35   ` [PATCH 8/8] PM / Domains: Handle errors from genpd's ->attach_dev() callback Geert Uytterhoeven
2015-01-29 10:32 ` [PATCH 0/8] PM / Domains: Re-structure code for adding/removing devices to genpd Geert Uytterhoeven
2015-02-04 14:39 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422389625-11730-9-git-send-email-ulf.hansson@linaro.org \
    --to=ulf.hansson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).