linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: arm64: USB_ARCH_HAS_EHCI
Date: Wed, 28 Jan 2015 10:46:45 +0100	[thread overview]
Message-ID: <1422438405.5666.16.camel@x220> (raw)
In-Reply-To: <alpine.DEB.2.02.1501272130470.19947@utopia.booyaka.com>

On Tue, 2015-01-27 at 21:31 +0000, Paul Walmsley wrote:
> On Tue, 27 Jan 2015, Paul Bolle wrote:
> 
> > Your commit d035fdfa27ac ("arm64: Add Tegra132 support") is included in
> > today's linux-next (ie, next-20150127). I noticed because a script I use
> > to check linux-next spotted a minor problem with it.
> > 
> > It adds a select for the Kconfig symbol USB_ARCH_HAS_EHCI. That Kconfig
> > was obsoleted in v3.11 and removed in v3.15. See commit b797b76fb464
> > ("usb: host: remove USB_ARCH_HAS_?HCI"). That select is now a nop.
> > 
> > Should I submit the trivial patch to remove that line or do you prefer
> > to do that yourself?
> 
> Thanks, I'll post a new version.

I just noticed that your commit added another unneeded select. The entry
for ARCH_TEGRA selects HAVE_SMP, but HAVE_SMP is only available on arm
or xtensa. There's no point in selecting it in arm64.

(The patch I submitted in https://lkml.org/lkml/2014/9/30/578 would have
warned about this. See https://lkml.org/lkml/2014/9/30/577 for an
introduction. I'll see if I can get Michal Marek to put that patch in a
tree that is part of linux-next.)


Paul Bolle

  reply	other threads:[~2015-01-28  9:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  9:43 arm64: USB_ARCH_HAS_EHCI Paul Bolle
2015-01-27 21:31 ` Paul Walmsley
2015-01-28  9:46   ` Paul Bolle [this message]
2015-01-28 16:25     ` Paul Walmsley
2015-01-28 21:00       ` Paul Bolle
2015-01-28 21:12         ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422438405.5666.16.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).