public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: eddie.huang@mediatek.com (Eddie Huang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option
Date: Mon, 2 Feb 2015 13:33:22 +0800	[thread overview]
Message-ID: <1422855202.26131.31.camel@mtksdaap41> (raw)
In-Reply-To: <20150202052423.GA3346@kroah.com>

Hi Peter,

On Sun, 2015-02-01 at 21:24 -0800, Greg Kroah-Hartman wrote:
> On Mon, Feb 02, 2015 at 12:15:31AM -0500, Peter Hurley wrote:
> > On 02/01/2015 11:28 PM, Greg Kroah-Hartman wrote:
> > > On Sun, Feb 01, 2015 at 10:45:12PM -0500, Peter Hurley wrote:
> > >> On 02/01/2015 10:16 PM, Eddie Huang wrote:
> > 
> > >> I'll respin proper patches on top of Greg's tty-testing branch with reverts
> > >> for the noinit options. I noticed that one of the noinit patches actually
> > >> has the linkage for the mtk earlycon, so I'll be sure to preserve that.
> > > 
> > > I can just drop the patches in the tty-testing branch, that's what it is
> > > there for :)
> > > 
> > > Just let me know the specific patches and I will do so, thanks.
> > 
> > Well that pretty much means dropping the 3 patches that add earlycon to
> > 8250_mtk and then applying my patch (needs fixed to apply cleanly, which
> > I can do) and then applying a fixed-up replacement patch to add earlycon
> > to 8250_mtk (which I can also supply).
> > 
> > Is that the way you want to go?
> 
> Sounds good to me, send your patch, and I'll fix it all up tomorrow.
> 
> thanks,
> 
> greg k-h

Actually, your patch is a little different from my original idea.
Although my use case only care about divisor now, but other hardware
setting is still hard-code, not from parameter. In init_port()
function:   
	serial8250_early_out(port, UART_LCR, 0x3); /* 8n1 */
	serial8250_early_out(port, UART_IER, 0);/* no interrupt */
	serial8250_early_out(port, UART_FCR, 0); /* no fifo */
	serial8250_early_out(port, UART_MCR, 0x3); /* DTR + RTS */

This is why I propose a new option "noinit".

After checking further, in my case, I found that your patch should be
unnecessary because if skip baudrate, probe_baud() read DLL/DLM register
and init_port() write the same DLL/DLM value back, no touch any high
speed register, which means keep uart divisor setting as loader

Since I don't take "console=uart,mmio32,<addr>,noinit" into
consideration, it is good to drop my patches in the tty-testing branch.
For my case, I can send another series without noinit, just 8250_mtk.c
and its linkage modification in 8250_early.c

Eddie

  reply	other threads:[~2015-02-02  5:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 13:08 [PATCH v2 0/4] tty: serial: Add earlycon support to MT8173 SoC Eddie Huang
2015-01-12 13:08 ` [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option Eddie Huang
2015-01-12 15:35   ` Arnd Bergmann
2015-01-12 16:08     ` Alan Cox
2015-01-13  1:05       ` Eddie Huang
2015-02-01 16:27   ` Peter Hurley
2015-02-01 18:26     ` Peter Hurley
2015-02-02  3:16       ` Eddie Huang
2015-02-02  3:45         ` Peter Hurley
2015-02-02  4:28           ` Greg Kroah-Hartman
2015-02-02  5:15             ` Peter Hurley
2015-02-02  5:24               ` Greg Kroah-Hartman
2015-02-02  5:33                 ` Eddie Huang [this message]
2015-02-02  5:43                   ` Peter Hurley
2015-02-02 18:46                     ` Greg Kroah-Hartman
2015-02-02  2:45     ` Eddie Huang
2015-02-02  3:27       ` Peter Hurley
2015-01-12 13:08 ` [PATCH v2 2/4] tty: serial: 8250_mtk: Add earlycon Eddie Huang
2015-01-12 13:08 ` [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 earlycon support Eddie Huang
2015-01-12 13:08 ` [PATCH v2 4/4] Document: Modify 8250 earlycon kernel parameters Eddie Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422855202.26131.31.camel@mtksdaap41 \
    --to=eddie.huang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox