From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6268CC87FCA for ; Fri, 25 Jul 2025 17:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Boet0sQ6t0VHwTkIVD5mIWeVJs2/6kN6hXhM0zHjkC0=; b=zBh+iPFHMJqjGsY8jTVOErNmID DnjLzLqeYnpF/BfYVTGEGJo8mLJmQcaW7FMjCb1ZJWOqExUWz57+7hkkzT+KJrzV1WVLovX8CbuVw EFdiObchf3nywmrvVWuXP88IWfcumG2/4MiYRF1FrvLgsfRhjQuWDCADR1Y2YVdtvsI5FBxA8MMZO dXgxSZi4ax2Q028xg+NPay+d3mV8Oy4SfayBx6U4CDnLJZpVDJSmtXjr2JEkOxUJbcZi6sBSTbi6K QYDn23kyuuMTL/whW9r9vZRKxlI5256pPg/SL1K08YXfTW00VTPS3S2jFMJIe9GdCtG1fezRbLzmr KaUEyM8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ufLwo-0000000AIpK-1J8n; Fri, 25 Jul 2025 17:11:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ufLrs-0000000AICC-2jmH for linux-arm-kernel@lists.infradead.org; Fri, 25 Jul 2025 17:06:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 556171A00; Fri, 25 Jul 2025 10:05:53 -0700 (PDT) Received: from [10.1.197.43] (eglon.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 17E913F66E; Fri, 25 Jul 2025 10:05:55 -0700 (PDT) Message-ID: <1422ff0e-6aa3-42de-ba12-4dff32e7505d@arm.com> Date: Fri, 25 Jul 2025 18:05:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 06/36] ACPI / PPTT: Stop acpi_count_levels() expecting callers to clear levels To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Ben Horgan , Rohit Mathew , Shanker Donthineni , Zeng Heng , Lecopzer Chen , Carl Worth , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Sudeep Holla References: <20250711183648.30766-1-james.morse@arm.com> <20250711183648.30766-7-james.morse@arm.com> <20250716165142.00002c46@huawei.com> Content-Language: en-GB From: James Morse In-Reply-To: <20250716165142.00002c46@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250725_100600_813930_9B81B023 X-CRM114-Status: GOOD ( 24.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On 16/07/2025 16:51, Jonathan Cameron wrote: > On Fri, 11 Jul 2025 18:36:18 +0000 > James Morse wrote: > >> acpi_count_levels() passes the number of levels back via a pointer argument. >> It also passes this to acpi_find_cache_level() as the starting_level, and >> preserves this value as it walks up the cpu_node tree counting the levels. >> >> The only caller acpi_get_cache_info() happens to have already initialised >> levels to zero, which acpi_count_levels() depends on to get the correct >> result. >> >> Explicitly zero the levels variable, so the count always starts at zero. >> This saves any additional callers having to work out they need to do this. > This is all a bit fiddly as we now end up with that initialized in various > different places. I've debugged this one a few times, (turns out I'm forgetful) ... I figured doing this was better than adding a comment to warn others. As its static, I figured it was something the compiler can optimise out if there is a duplicate. (I couldn't find any initialisation I could remove because of this) > Perhaps simpler to have acpi_count_levels() return the > number of levels rather than void. Then return number of levels rather > than 0 on success from acpi_get_cache_info(). Negative error codes used > for failure just like now. > > That would leave only a local variable in acpi_count_levels being > initialized to 0 and passed to acpi_find_cache_level() before being > returned when the loop terminates. > > I think that sequence then makes it such that we can't fail to > initialize it at without the compiler noticing and screaming. > > Requires a few changes from if (ret) to if (ret < 0) at callers > of acpi_get_cache_info() but looks simple (says the person who > hasn't actually coded it!) Breaking the symmetry between levels and split_levels is an argument against this. I think within pptt.c this is fine, because 'level's is used internally as 'starting_level', and this expectation it was initialised to zero is a nasty surprise. But exposing that from acpi_get_cache_info() looks stranger - and would need to touch users in cacheinfo, arm64, riscv. I've updated acpi_count_levels() to look as you describe - that at least makes it harder to miss this in future. (not sure whether it saves anything) >> diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c >> index 13619b1b821b..13ca2eee3b98 100644 >> --- a/drivers/acpi/pptt.c >> +++ b/drivers/acpi/pptt.c >> @@ -183,7 +183,7 @@ acpi_find_cache_level(struct acpi_table_header *table_hdr, >> * @cpu_node: processor node we wish to count caches for >> * @levels: Number of levels if success. >> * @split_levels: Number of split cache levels (data/instruction) if >> - * success. Can by NULL. >> + * success. Can be NULL. > > Grumpy reviewer hat. Unrelated cleanup up - good to have but not in this patch where > it's a distraction. I was hoping diff would keep it as one hunk. Happy to leave it tyopd! Thanks, James