linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ddutile@redhat.com (Donald Dutile)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Change 'Call trace' to 'Call Trace' for tool scanners
Date: Thu,  5 Feb 2015 12:30:27 -0500	[thread overview]
Message-ID: <1423157427-41997-1-git-send-email-ddutile@redhat.com> (raw)

Receiving reports from service folks that arm64 uses
'Call trace' when dumping stack, instead of the more familiar
'Call Trace'; the former is not being seen by tools that
scan for the latter text.  Checking various arches,
it appears the mainstream server arches (ia64, mips, ppc,
s390, sparc, x86) use 'Call Trace'.
This kernel tools script scans for the latter text string as well
  tools/testing/selftests/rcutorture/bin/parse-console.sh
so it doesn't appear to be arch or vendor specific.

Expecting there aren't a significant number of arm64 dump
scanners matching on 'Call trace' so recommend making this change
now to minimize changes to dump scanning tools for arm64 servers.

Signed-off-by: Donald Dutile <ddutile@redhat.com>
---
 arch/arm64/kernel/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index 0a801e3..832e721 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -155,7 +155,7 @@ static void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk)
 		frame.pc = thread_saved_pc(tsk);
 	}
 
-	pr_emerg("Call trace:\n");
+	pr_emerg("Call Trace:\n");
 	while (1) {
 		unsigned long where = frame.pc;
 		int ret;
-- 
1.7.10.2.552.gaa3bb87

             reply	other threads:[~2015-02-05 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 17:30 Donald Dutile [this message]
2015-02-05 17:37 ` [PATCH] arm64: Change 'Call trace' to 'Call Trace' for tool scanners Russell King - ARM Linux
2015-02-05 18:18   ` Don Dutile
2015-02-05 18:30     ` Russell King - ARM Linux
2015-02-05 18:46       ` Don Dutile
2015-02-06 15:34 ` Catalin Marinas
2015-02-06 18:43   ` Don Dutile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423157427-41997-1-git-send-email-ddutile@redhat.com \
    --to=ddutile@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).