linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs
@ 2015-02-11  3:52 Tyler Baker
  2015-02-11  3:52 ` [PATCH 1/2] ARM: multi_v7_defconfig: increase the number of maximum number of CPUs to 16 Tyler Baker
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Tyler Baker @ 2015-02-11  3:52 UTC (permalink / raw)
  To: linux-arm-kernel

Hello,

I have recently been reviewing the kernel warnings generated from the kernelci.org boot farm, and have discovered that the HiP04 and a80-optimus boards have more CPUs then the maximum allowed in a few of the ARM defconfigs. This series fixes those warnings by increasing the maximum number of CPUs. I went ahead and boot tested these patches on various boards [1] to insure there are no regressions introduced when increasing the number of CPUs. 

Any comments would be appreciated. Perhaps we may want to increase these limits further?

Thanks,

[1] http://kernelci.org/boot/all/job/tbaker/kernel/v3.19-rc4-845-g9f29e39a74a2/ 

Tyler Baker (2):
  ARM: multi_v7_defconfig: increase the number of maximum number of CPUs to
    16
  ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8

 arch/arm/configs/multi_v7_defconfig | 2 +-
 arch/arm/configs/sunxi_defconfig    | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: multi_v7_defconfig: increase the number of maximum number of CPUs to 16
  2015-02-11  3:52 [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Tyler Baker
@ 2015-02-11  3:52 ` Tyler Baker
  2015-02-11  3:52 ` [PATCH 2/2] ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8 Tyler Baker
  2015-03-04 22:43 ` [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Arnd Bergmann
  2 siblings, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-02-11  3:52 UTC (permalink / raw)
  To: linux-arm-kernel

The HiSilicon HiP04 has 16 CPUs. I propose we increase the maximum number of CPUs to 16 to avoid the following warning identified during automated boot testing [1].

------------[ cut here ]------------
WARNING: CPU: 0 PID: 0 at ../arch/arm/kernel/devtree.c:144 arm_dt_init_cpu_maps+0x118/0x1e8()
DT /cpu 9 nodes greater than max cores 8, capping them
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Not tainted 3.19.0-00528-gbdccc4edeb03 #1
Hardware name: Hisilicon HiP04 (Flattened Device Tree)
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0x78/0x94)
[] (dump_stack) from [] (warn_slowpath_common+0x74/0xb0)
[] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40)
[] (warn_slowpath_fmt) from [] (arm_dt_init_cpu_maps+0x118/0x1e8)
[] (arm_dt_init_cpu_maps) from [] (setup_arch+0x638/0x9a0)
[] (setup_arch) from [] (start_kernel+0x8c/0x3b4)
[] (start_kernel) from [<10208074>] (0x10208074)
---[ end trace cb88537fdc8fa200 ]---

[1] http://storage.kernelci.org/mainline/v3.19-528-gbdccc4edeb03/arm-multi_v7_defconfig/lab-tbaker/boot-hip04-d01.html

Cc: Olof Johansson <olof@lixom.net>
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index e8a4c95..ad57306 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -86,7 +86,7 @@ CONFIG_PCI_MVEBU=y
 CONFIG_PCI_TEGRA=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_SMP=y
-CONFIG_NR_CPUS=8
+CONFIG_NR_CPUS=16
 CONFIG_HIGHPTE=y
 CONFIG_CMA=y
 CONFIG_ARM_APPENDED_DTB=y
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8
  2015-02-11  3:52 [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Tyler Baker
  2015-02-11  3:52 ` [PATCH 1/2] ARM: multi_v7_defconfig: increase the number of maximum number of CPUs to 16 Tyler Baker
@ 2015-02-11  3:52 ` Tyler Baker
  2015-02-16 12:59   ` Maxime Ripard
  2015-03-04 22:43 ` [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Arnd Bergmann
  2 siblings, 1 reply; 6+ messages in thread
From: Tyler Baker @ 2015-02-11  3:52 UTC (permalink / raw)
  To: linux-arm-kernel

The a80 optimus has 8 CPUs. I propose we increase the maximum number of CPUs to 8 to avoid the following warning identified during automated boot testing [1].

------------[ cut here ]------------
WARNING: CPU: 0 PID: 0 at ../arch/arm/kernel/devtree.c:144 arm_dt_init_cpu_maps+0x110/0x1e0()
DT /cpu 5 nodes greater than max cores 4, capping them
CPU: 0 PID: 0 Comm: swapper Not tainted 3.19.0-00528-gbdccc4edeb03 #1
Hardware name: Allwinner sun9i Family
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0x74/0x90)
[] (dump_stack) from [] (warn_slowpath_common+0x70/0xac)
[] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40)
[] (warn_slowpath_fmt) from [] (arm_dt_init_cpu_maps+0x110/0x1e0)
[] (arm_dt_init_cpu_maps) from [] (setup_arch+0x634/0x8d4)
[] (setup_arch) from [] (start_kernel+0x88/0x3ac)
[] (start_kernel) from [<20008074>] (0x20008074)
---[ end trace cb88537fdc8fa200 ]---

[1] http://storage.kernelci.org/mainline/v3.19-528-gbdccc4edeb03/arm-sunxi_defconfig/lab-tbaker/boot-sun9i-a80-optimus.html

Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Olof Johansson <olof@lixom.net>
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
 arch/arm/configs/sunxi_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index 38840a8..8f6a570 100644
--- a/arch/arm/configs/sunxi_defconfig
+++ b/arch/arm/configs/sunxi_defconfig
@@ -4,6 +4,7 @@ CONFIG_BLK_DEV_INITRD=y
 CONFIG_PERF_EVENTS=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_SMP=y
+CONFIG_NR_CPUS=8
 CONFIG_AEABI=y
 CONFIG_HIGHMEM=y
 CONFIG_HIGHPTE=y
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8
  2015-02-11  3:52 ` [PATCH 2/2] ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8 Tyler Baker
@ 2015-02-16 12:59   ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2015-02-16 12:59 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Feb 10, 2015 at 07:52:28PM -0800, Tyler Baker wrote:
> The a80 optimus has 8 CPUs. I propose we increase the maximum number of CPUs to 8 to avoid the following warning identified during automated boot testing [1].
> 
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 0 at ../arch/arm/kernel/devtree.c:144 arm_dt_init_cpu_maps+0x110/0x1e0()
> DT /cpu 5 nodes greater than max cores 4, capping them
> CPU: 0 PID: 0 Comm: swapper Not tainted 3.19.0-00528-gbdccc4edeb03 #1
> Hardware name: Allwinner sun9i Family
> [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
> [] (show_stack) from [] (dump_stack+0x74/0x90)
> [] (dump_stack) from [] (warn_slowpath_common+0x70/0xac)
> [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40)
> [] (warn_slowpath_fmt) from [] (arm_dt_init_cpu_maps+0x110/0x1e0)
> [] (arm_dt_init_cpu_maps) from [] (setup_arch+0x634/0x8d4)
> [] (setup_arch) from [] (start_kernel+0x88/0x3ac)
> [] (start_kernel) from [<20008074>] (0x20008074)
> ---[ end trace cb88537fdc8fa200 ]---
> 
> [1] http://storage.kernelci.org/mainline/v3.19-528-gbdccc4edeb03/arm-sunxi_defconfig/lab-tbaker/boot-sun9i-a80-optimus.html
> 
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>

Applied, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150216/405acdd9/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs
  2015-02-11  3:52 [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Tyler Baker
  2015-02-11  3:52 ` [PATCH 1/2] ARM: multi_v7_defconfig: increase the number of maximum number of CPUs to 16 Tyler Baker
  2015-02-11  3:52 ` [PATCH 2/2] ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8 Tyler Baker
@ 2015-03-04 22:43 ` Arnd Bergmann
  2015-03-04 22:46   ` Tyler Baker
  2 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2015-03-04 22:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Tuesday 10 February 2015 19:52:26 Tyler Baker wrote:
> I have recently been reviewing the kernel warnings generated from the kernelci.org boot farm, and have discovered that the HiP04 and a80-optimus boards have more CPUs then the maximum allowed in a few of the ARM defconfigs. This series fixes those warnings by increasing the maximum number of CPUs. I went ahead and boot tested these patches on various boards [1] to insure there are no regressions introduced when increasing the number of CPUs. 
> 
> Any comments would be appreciated. Perhaps we may want to increase these limits further?

I've applied your version. Increasing the limit more would mainly cause memory
to be wasted, so I don't think that's a good idea until we need to support
other hardware.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs
  2015-03-04 22:43 ` [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Arnd Bergmann
@ 2015-03-04 22:46   ` Tyler Baker
  0 siblings, 0 replies; 6+ messages in thread
From: Tyler Baker @ 2015-03-04 22:46 UTC (permalink / raw)
  To: linux-arm-kernel

On 4 March 2015 at 14:43, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 10 February 2015 19:52:26 Tyler Baker wrote:
>> I have recently been reviewing the kernel warnings generated from the kernelci.org boot farm, and have discovered that the HiP04 and a80-optimus boards have more CPUs then the maximum allowed in a few of the ARM defconfigs. This series fixes those warnings by increasing the maximum number of CPUs. I went ahead and boot tested these patches on various boards [1] to insure there are no regressions introduced when increasing the number of CPUs.
>>
>> Any comments would be appreciated. Perhaps we may want to increase these limits further?
>
> I've applied your version. Increasing the limit more would mainly cause memory
> to be wasted, so I don't think that's a good idea until we need to support
> other hardware.

That seems sensible to me, thanks for picking this up.

>
>         Arnd

Tyler

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-03-04 22:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-11  3:52 [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Tyler Baker
2015-02-11  3:52 ` [PATCH 1/2] ARM: multi_v7_defconfig: increase the number of maximum number of CPUs to 16 Tyler Baker
2015-02-11  3:52 ` [PATCH 2/2] ARM: sunxi_defconfig: increase the number of maximum number of CPUs to 8 Tyler Baker
2015-02-16 12:59   ` Maxime Ripard
2015-03-04 22:43 ` [PATCH 0/2] ARM: multi_v7_defconfig, sunxi_defconfig: increase maximum number of CPUs Arnd Bergmann
2015-03-04 22:46   ` Tyler Baker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).