From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] ARM: hip04: set ARCH_NR_GPIO to 128
Date: Tue, 02 Dec 2014 09:42:31 +0100 [thread overview]
Message-ID: <142367414.tx9doeBDv9@wuerfel> (raw)
In-Reply-To: <547D5FA7.3040307@gmail.com>
On Tuesday 02 December 2014 14:43:51 Zhou Wang wrote:
>
> how about a patch like this, we read the base from the dts here.
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index e8e98ca..0c40f53 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -107,11 +107,16 @@ struct gpio_chip *gpiod_to_chip(const struct
> gpio_desc *desc)
> EXPORT_SYMBOL_GPL(gpiod_to_chip);
>
> /* dynamic allocation of GPIOs, e.g. on a hotplugged device */
> -static int gpiochip_find_base(int ngpio)
> +static int gpiochip_find_base(struct gpio_chip *gpio_chip)
> {
> struct gpio_chip *chip;
> + int ngpio = gpio_chip->ngpio;
> int base = ARCH_NR_GPIOS - ngpio;
>
> + /* just prototype */
> + if (!of_property_read_u32(gpio_chip->dev->of_node, "base", &base))
> + return base;
> +
I don't think that would be appropriate. The concept of a gpio number
base is implementation specific to current Linux versions and we want
to get rid of that in the future, so it should not be part of an
OS-independent spec.
Arnd
next prev parent reply other threads:[~2014-12-02 8:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 6:29 [PATCH v3 0/2] ARM: hip04: add GPIO support Zhou Wang
2014-11-28 6:29 ` [PATCH v3 1/2] ARM: hip04: set ARCH_NR_GPIO to 128 Zhou Wang
2014-11-28 9:33 ` Arnd Bergmann
2014-11-28 15:54 ` Linus Walleij
2014-11-28 21:16 ` Arnd Bergmann
2014-11-29 7:14 ` Alexandre Courbot
2014-11-29 7:22 ` Zhou Wang
2014-11-29 7:11 ` Zhou Wang
2014-12-01 14:04 ` Linus Walleij
2014-12-01 14:47 ` Arnd Bergmann
2014-12-02 6:43 ` Zhou Wang
2014-12-02 8:42 ` Arnd Bergmann [this message]
2014-12-04 6:49 ` Zhou Wang
2014-11-28 6:29 ` [PATCH v3 2/2] ARM: dts: hip04: add GPIO pieces Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=142367414.tx9doeBDv9@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox