From: trond.myklebust@primarydata.com (Trond Myklebust)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] nfs: do not export discarded symbols
Date: Thu, 12 Mar 2015 11:58:38 -0400 [thread overview]
Message-ID: <1426175918.15787.3.camel@primarydata.com> (raw)
In-Reply-To: <3173686.FPJdK9jLbA@wuerfel>
On Wed, 2015-03-11 at 14:37 +0100, Arnd Bergmann wrote:
> The function nfs4_pnfs_v3_ds_connect_unload is exported so it can be
> used by other modules, but is also marked '__exit' and will be
> discarded when built into the kernel, as pointed out by this
> linker error:
>
> `nfs4_pnfs_v3_ds_connect_unload' referenced in section `___ksymtab_gpl+nfs4_pnfs_v3_ds_connect_unload' of fs/built-in.o: defined in discarded section `.exit.text' of fs/built-in.o
>
> This removes the __exit annotation to make it safe to call this function.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5f01d9539496 ("nfs41: create NFSv3 DS connection if specified")
>
> diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
> index 54e36b38fb5f..8582dae5ae99 100644
> --- a/fs/nfs/pnfs_nfs.c
> +++ b/fs/nfs/pnfs_nfs.c
> @@ -561,7 +561,7 @@ static bool load_v3_ds_connect(void)
> return(get_v3_ds_connect != NULL);
> }
>
> -void __exit nfs4_pnfs_v3_ds_connect_unload(void)
> +void nfs4_pnfs_v3_ds_connect_unload(void)
> {
> if (get_v3_ds_connect) {
> symbol_put(nfs3_set_ds_client);
>
Thanks! Applied...
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust at primarydata.com
next prev parent reply other threads:[~2015-03-12 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 13:37 [PATCH] nfs: do not export discarded symbols Arnd Bergmann
2015-03-11 14:52 ` Baruch Siach
2015-03-12 15:58 ` Trond Myklebust [this message]
2015-04-09 9:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426175918.15787.3.camel@primarydata.com \
--to=trond.myklebust@primarydata.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).