linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm64: head.S: fix __boot_cpu_mode alignment
Date: Fri, 13 Mar 2015 16:14:35 +0000	[thread overview]
Message-ID: <1426263277-9827-3-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1426263277-9827-1-git-send-email-mark.rutland@arm.com>

We currently align the allocation of the __boot_cpu_mode data _after_
allocating the label. Thus the label may point to padding before the
data. While we seem to have gotten away with this so far, it's not a
good idea to rely on any existing alignment in the object.

Perform the alignment padding before allocating the label to avoid this
possibility.

Fixes: c218bca74eeafa2f ("arm64: Relax the kernel cache requirements for boot")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
---
 arch/arm64/kernel/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
index 8ce88e0..07f9305 100644
--- a/arch/arm64/kernel/head.S
+++ b/arch/arm64/kernel/head.S
@@ -585,8 +585,8 @@ ENDPROC(set_cpu_boot_mode_flag)
  * zeroing of .bss would clobber it.
  */
 	.pushsection	.data..cacheline_aligned
-ENTRY(__boot_cpu_mode)
 	.align	L1_CACHE_SHIFT
+ENTRY(__boot_cpu_mode)
 	.long	BOOT_CPU_MODE_EL2
 	.long	0
 	.popsection
-- 
1.9.1

  parent reply	other threads:[~2015-03-13 16:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 16:14 [PATCH 0/4] arm64: boot fixes/updates Mark Rutland
2015-03-13 16:14 ` [PATCH 1/4] arm64: apply alternatives for !SMP kernels Mark Rutland
2015-03-17 16:01   ` Ard Biesheuvel
2015-03-13 16:14 ` Mark Rutland [this message]
2015-03-13 16:14 ` [PATCH 3/4] arm64: fix hyp mode mismatch detection Mark Rutland
2015-03-13 20:21   ` Ard Biesheuvel
2015-03-16 10:56     ` Mark Rutland
2015-03-16 11:03       ` Marc Zyngier
2015-03-16 11:05         ` Ard Biesheuvel
2015-03-17 15:58   ` Ard Biesheuvel
2015-03-13 16:14 ` [PATCH 4/4] arm64: log CPU boot modes Mark Rutland
2015-03-17 15:58   ` Ard Biesheuvel
2015-03-14  7:59 ` [PATCH 0/4] arm64: boot fixes/updates Ard Biesheuvel
2015-03-16 10:53   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426263277-9827-3-git-send-email-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).