* [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file
@ 2015-03-12 6:51 Axel Lin
2015-03-12 10:32 ` Matthias Brugger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Axel Lin @ 2015-03-12 6:51 UTC (permalink / raw)
To: linux-arm-kernel
Fix below build error:
CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory
compilation terminated.
make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
make[2]: *** [drivers/pinctrl/mediatek] Error 2
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
index 5019cef..e17aedb 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
@@ -16,7 +16,7 @@
#define __PINCTRL_MTK_MT8135_H
#include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
static const struct mtk_desc_pin mtk_pins_mt8135[] = {
MTK_PIN(
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
index c1a3ca0..13e5b68 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
@@ -16,7 +16,7 @@
#define __PINCTRL_MTK_MT8173_H
#include <linux/pinctrl/pinctrl.h>
-#include <pinctrl-mtk-common.h>
+#include "pinctrl-mtk-common.h"
static const struct mtk_desc_pin mtk_pins_mt8173[] = {
MTK_PIN(
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file
2015-03-12 6:51 [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file Axel Lin
@ 2015-03-12 10:32 ` Matthias Brugger
2015-03-12 10:41 ` Guenter Roeck
2015-03-13 19:44 ` Hongzhou Yang
2015-03-18 12:07 ` Linus Walleij
2 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2015-03-12 10:32 UTC (permalink / raw)
To: linux-arm-kernel
2015-03-12 7:51 GMT+01:00 Axel Lin <axel.lin@ingics.com>:
> Fix below build error:
> CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
> In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory
> compilation terminated.
> make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
> make[2]: *** [drivers/pinctrl/mediatek] Error 2
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
The fix from Guenter already addresses mt8135 case [0].
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
for the mt8173 part.
Cheers,
Matthias
[0] https://lkml.org/lkml/2015/3/11/510
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
> index 5019cef..e17aedb 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
> @@ -16,7 +16,7 @@
> #define __PINCTRL_MTK_MT8135_H
>
> #include <linux/pinctrl/pinctrl.h>
> -#include <pinctrl-mtk-common.h>
> +#include "pinctrl-mtk-common.h"
>
> static const struct mtk_desc_pin mtk_pins_mt8135[] = {
> MTK_PIN(
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> index c1a3ca0..13e5b68 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> @@ -16,7 +16,7 @@
> #define __PINCTRL_MTK_MT8173_H
>
> #include <linux/pinctrl/pinctrl.h>
> -#include <pinctrl-mtk-common.h>
> +#include "pinctrl-mtk-common.h"
>
> static const struct mtk_desc_pin mtk_pins_mt8173[] = {
> MTK_PIN(
> --
> 1.9.1
>
>
>
--
motzblog.wordpress.com
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file
2015-03-12 10:32 ` Matthias Brugger
@ 2015-03-12 10:41 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2015-03-12 10:41 UTC (permalink / raw)
To: linux-arm-kernel
On 03/12/2015 03:32 AM, Matthias Brugger wrote:
> 2015-03-12 7:51 GMT+01:00 Axel Lin <axel.lin@ingics.com>:
>> Fix below build error:
>> CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
>> In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
>> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory
>> compilation terminated.
>> make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
>> make[2]: *** [drivers/pinctrl/mediatek] Error 2
>> make[1]: *** [drivers/pinctrl] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> The fix from Guenter already addresses mt8135 case [0].
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> for the mt8173 part.
>
Axel's patch is more complete, so if my patch has not been applied yet
I would suggest to take this one instead.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> Cheers,
> Matthias
>
> [0] https://lkml.org/lkml/2015/3/11/510
>
>> ---
>> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
>> drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
>> index 5019cef..e17aedb 100644
>> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
>> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
>> @@ -16,7 +16,7 @@
>> #define __PINCTRL_MTK_MT8135_H
>>
>> #include <linux/pinctrl/pinctrl.h>
>> -#include <pinctrl-mtk-common.h>
>> +#include "pinctrl-mtk-common.h"
>>
>> static const struct mtk_desc_pin mtk_pins_mt8135[] = {
>> MTK_PIN(
>> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
>> index c1a3ca0..13e5b68 100644
>> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
>> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
>> @@ -16,7 +16,7 @@
>> #define __PINCTRL_MTK_MT8173_H
>>
>> #include <linux/pinctrl/pinctrl.h>
>> -#include <pinctrl-mtk-common.h>
>> +#include "pinctrl-mtk-common.h"
>>
>> static const struct mtk_desc_pin mtk_pins_mt8173[] = {
>> MTK_PIN(
>> --
>> 1.9.1
>>
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file
2015-03-12 6:51 [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file Axel Lin
2015-03-12 10:32 ` Matthias Brugger
@ 2015-03-13 19:44 ` Hongzhou Yang
2015-03-18 12:07 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Hongzhou Yang @ 2015-03-13 19:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2015-03-12 at 14:51 +0800, Axel Lin wrote:
> Fix below build error:
> CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
> In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory
> compilation terminated.
> make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
> make[2]: *** [drivers/pinctrl/mediatek] Error 2
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h | 2 +-
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
> index 5019cef..e17aedb 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h
> @@ -16,7 +16,7 @@
> #define __PINCTRL_MTK_MT8135_H
>
> #include <linux/pinctrl/pinctrl.h>
> -#include <pinctrl-mtk-common.h>
> +#include "pinctrl-mtk-common.h"
>
> static const struct mtk_desc_pin mtk_pins_mt8135[] = {
> MTK_PIN(
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> index c1a3ca0..13e5b68 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8173.h
> @@ -16,7 +16,7 @@
> #define __PINCTRL_MTK_MT8173_H
>
> #include <linux/pinctrl/pinctrl.h>
> -#include <pinctrl-mtk-common.h>
> +#include "pinctrl-mtk-common.h"
>
> static const struct mtk_desc_pin mtk_pins_mt8173[] = {
> MTK_PIN(
Hi Axel,
Thank you very much.
Acked-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
Hongzhou
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file
2015-03-12 6:51 [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file Axel Lin
2015-03-12 10:32 ` Matthias Brugger
2015-03-13 19:44 ` Hongzhou Yang
@ 2015-03-18 12:07 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2015-03-18 12:07 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 12, 2015 at 7:51 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Fix below build error:
> CC drivers/pinctrl/mediatek/pinctrl-mt8135.o
> In file included from drivers/pinctrl/mediatek/pinctrl-mt8135.c:24:0:
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8135.h:19:32: fatal error: pinctrl-mtk-common.h: No such file or directory
> compilation terminated.
> make[3]: *** [drivers/pinctrl/mediatek/pinctrl-mt8135.o] Error 1
> make[2]: *** [drivers/pinctrl/mediatek] Error 2
> make[1]: *** [drivers/pinctrl] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied. Partially, since Guenther already fixed one oneliner.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-18 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 6:51 [PATCH] pinctrl: mediatek: mt8135/mt8173: Fix build error due to missing include file Axel Lin
2015-03-12 10:32 ` Matthias Brugger
2015-03-12 10:41 ` Guenter Roeck
2015-03-13 19:44 ` Hongzhou Yang
2015-03-18 12:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).